bindings: Use V8 MaybeLocal<> APIs in Dictionary class

Source/bindings/core/v8/Dictionary.h

Index: Source/bindings/core/v8/Dictionary.h
diff --git a/Source/bindings/core/v8/Dictionary.h b/Source/bindings/core/v8/Dictionary.h
index 3a5139d521149d067f615f06470d72b38d48da37..5cdb27f25bf16774cdbe9eaf23b54da2e446342f 100644
--- a/Source/bindings/core/v8/Dictionary.h
+++ b/Source/bindings/core/v8/Dictionary.h
@@ -45,7 +45,7 @@ namespace blink {
 // Dictionary class provides ways to retrieve property values as C++ objects
 // from a V8 object. Instances of this class must not outlive V8's handle scope
 // because they hold a V8 value without putting it on persistent handles.
-class CORE_EXPORT Dictionary {
+class CORE_EXPORT Dictionary final {
     ALLOW_ONLY_INLINE_ALLOCATION();
 public:
     Dictionary();
@@ -110,16 +110,17 @@ public:
     bool hasProperty(const String&) const;
 
     v8::Isolate* isolate() const { return m_isolate; }
-
-    bool getKey(const String& key, v8::Local<v8::Value>&) const;
-
-private:
     v8::Local<v8::Context> v8Context() const
     {
         ASSERT(m_isolate);
         return m_isolate->GetCurrentContext();
     }
 
+    bool getKey(const String& key, v8::Local<v8::Value>&) const;
+
+private:
+    bool toObject(v8::Local<v8::Object>*) const;

[Yuki, 2015/03/27 06:48:33]

nit: Since you're using v8::Local<>& elsewhere, you might want to use non-const
reference here, too.

[bashi, 2015/03/27 07:05:48]

Done.

+
     v8::Handle<v8::Value> m_options;
     v8::Isolate* m_isolate;
     ExceptionState* m_exceptionState;