bindings: Use V8 MaybeLocal<> APIs in Dictionary class

Source/bindings/core/v8/DictionaryHelperForCore.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 48 matching lines @@
     return dictionary.get(key, value);
 }
 
 template <>
 bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, bool& value)
 {
     v8::Local<v8::Value> v8Value;
     if (!dictionary.get(key, v8Value))
         return false;
 
-    v8::Local<v8::Boolean> v8Bool = v8Value->ToBoolean(dictionary.isolate());
-    if (v8Bool.IsEmpty())
+    v8::MaybeLocal<v8::Boolean> maybeBool = v8Value->ToBoolean(dictionary.context());
+    v8::Local<v8::Boolean> v8Bool;
+    if (!maybeBool.ToLocal(&v8Bool) || v8Bool.IsEmpty())
         return false;
     value = v8Bool->Value();
     return true;
 }
 
 template <>
 bool DictionaryHelper::convert(const Dictionary& dictionary, Dictionary::ConversionContext& context, const String& key, bool& value)
 {
     Dictionary::ConversionContextScope scope(context);
     DictionaryHelper::get(dictionary, key, value);
     return true;
 }
 
 template <>
 bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, int32_t& value)
 {
     v8::Local<v8::Value> v8Value;
     if (!dictionary.get(key, v8Value))
         return false;
 
-    v8::Local<v8::Int32> v8Int32 = v8Value->ToInt32(dictionary.isolate());
-    if (v8Int32.IsEmpty())
+    v8::MaybeLocal<v8::Int32> maybeInt32 = v8Value->ToInt32(dictionary.context());
+    v8::Local<v8::Int32> v8Int32;
+    if (!maybeInt32.ToLocal(&v8Int32) || v8Int32.IsEmpty())
         return false;
     value = v8Int32->Value();
     return true;
 }
 
 template <>
 bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, double& value, bool& hasValue)
 {
     v8::Local<v8::Value> v8Value;
     if (!dictionary.get(key, v8Value)) {
@@ skipping 94 matching lines @@
     return true;
 }
 
 template<typename NumericType>
 bool getNumericType(const Dictionary& dictionary, const String& key, NumericType& value)
 {
     v8::Local<v8::Value> v8Value;
     if (!dictionary.get(key, v8Value))
         return false;
 
-    v8::Local<v8::Int32> v8Int32 = v8Value->ToInt32(dictionary.isolate());
-    if (v8Int32.IsEmpty())
+    v8::MaybeLocal<v8::Int32> maybeInt32 = v8Value->ToInt32(dictionary.context());
+    v8::Local<v8::Int32> v8Int32;
+    if (!maybeInt32.ToLocal(&v8Int32) || v8Int32.IsEmpty())
         return false;
     value = static_cast<NumericType>(v8Int32->Value());
     return true;
 }
 
 template <>
 bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, short& value)
 {
     return getNumericType<short>(dictionary, key, value);
 }
@@ skipping 10 matching lines @@
     return getNumericType<unsigned>(dictionary, key, value);
 }
 
 template <>
 bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, unsigned long& value)
 {
     v8::Local<v8::Value> v8Value;
     if (!dictionary.get(key, v8Value))
         return false;
 
-    v8::Local<v8::Integer> v8Integer = v8Value->ToInteger(dictionary.isolate());
-    if (v8Integer.IsEmpty())
+    v8::MaybeLocal<v8::Integer> maybeInteger = v8Value->ToInteger(dictionary.context());
+    v8::Local<v8::Integer> v8Integer;

[dcarney, 2015/03/06 07:42:44]

same here - macros everywhere

+    if (!maybeInteger.ToLocal(&v8Integer) || v8Integer.IsEmpty())
         return false;
     value = static_cast<unsigned long>(v8Integer->Value());
     return true;
 }
 
 template <>
 bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, unsigned long long& value)
 {
     v8::Local<v8::Value> v8Value;
     if (!dictionary.get(key, v8Value))
@@ skipping 314 matching lines @@
 
     value = toRefPtrWillBeMemberNativeArray<MessagePort, V8MessagePort>(v8Value, key, dictionary.isolate(), context.exceptionState());
 
     if (context.exceptionState().throwIfNeeded())
         return false;
 
     return true;
 }
 
 } // namespace blink