bindings: Use V8 MaybeLocal<> APIs in Dictionary class

Source/bindings/core/v8/DictionaryHelperForCore.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 47 matching lines @@
     return dictionary.get(key, value);
 }
 
 template <>
 CORE_EXPORT bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, bool& value)
 {
     v8::Local<v8::Value> v8Value;
     if (!dictionary.get(key, v8Value))
         return false;
 
-    v8::Local<v8::Boolean> v8Bool = v8Value->ToBoolean(dictionary.isolate());
-    if (v8Bool.IsEmpty())
-        return false;
-    value = v8Bool->Value();
-    return true;
+    return v8Call(v8Value->BooleanValue(dictionary.v8Context()), value);
 }
 
 template <>
 bool DictionaryHelper::convert(const Dictionary& dictionary, Dictionary::ConversionContext& context, const String& key, bool& value)
 {
     Dictionary::ConversionContextScope scope(context);
     DictionaryHelper::get(dictionary, key, value);
     return true;
 }
 
 template <>
 CORE_EXPORT bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, int32_t& value)
 {
     v8::Local<v8::Value> v8Value;
     if (!dictionary.get(key, v8Value))
         return false;
 
-    v8::Local<v8::Int32> v8Int32 = v8Value->ToInt32(dictionary.isolate());
-    if (v8Int32.IsEmpty())
-        return false;
-    value = v8Int32->Value();
-    return true;
+    return v8Call(v8Value->Int32Value(dictionary.v8Context()), value);
 }
 
 template <>
 CORE_EXPORT bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, double& value, bool& hasValue)
 {
     v8::Local<v8::Value> v8Value;
     if (!dictionary.get(key, v8Value)) {
         hasValue = false;
         return false;
     }
 
     hasValue = true;
-
-    v8::TryCatch block;
-    value = v8Value->NumberValue();
-    if (UNLIKELY(block.HasCaught())) {
-        block.ReThrow();
-        return false;
-    }
-    return true;
+    return v8Call(v8Value->NumberValue(dictionary.v8Context()), value);
 }
 
 template <>
 bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, double& value)
 {
     bool unused;
     return DictionaryHelper::get(dictionary, key, value, unused);
 }
 
 template <>
@@ skipping 67 matching lines @@
 {
     Dictionary::ConversionContextScope scope(context);
 
     DictionaryHelper::get(dictionary, key, value);
     return true;
 }
 
 template<typename NumericType>
 bool getNumericType(const Dictionary& dictionary, const String& key, NumericType& value)
 {
-    v8::Local<v8::Value> v8Value;
-    if (!dictionary.get(key, v8Value))
+    int32_t int32Value;
+    if (!DictionaryHelper::get(dictionary, key, int32Value))
         return false;
-
-    v8::Local<v8::Int32> v8Int32 = v8Value->ToInt32(dictionary.isolate());
-    if (v8Int32.IsEmpty())
-        return false;
-    value = static_cast<NumericType>(v8Int32->Value());
+    value = static_cast<NumericType>(int32Value);
     return true;
 }
 
 template <>
 bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, short& value)
 {
     return getNumericType<short>(dictionary, key, value);
 }
 
 template <>
 CORE_EXPORT bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, unsigned short& value)
 {
     return getNumericType<unsigned short>(dictionary, key, value);
 }
 
 template <>
 bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, unsigned& value)
 {
     return getNumericType<unsigned>(dictionary, key, value);
 }
 
 template <>
 bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, unsigned long& value)
 {
     v8::Local<v8::Value> v8Value;
     if (!dictionary.get(key, v8Value))
         return false;
 
-    v8::Local<v8::Integer> v8Integer = v8Value->ToInteger(dictionary.isolate());
-    if (v8Integer.IsEmpty())
+    int64_t int64Value;
+    if (!v8Call(v8Value->IntegerValue(dictionary.v8Context()), int64Value))
         return false;
-    value = static_cast<unsigned long>(v8Integer->Value());
+    value = int64Value;
     return true;
 }
 
 template <>
 bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, unsigned long long& value)
 {
     v8::Local<v8::Value> v8Value;
     if (!dictionary.get(key, v8Value))
         return false;
 
-    v8::TryCatch block;
-    double d = v8Value->NumberValue();
-    if (UNLIKELY(block.HasCaught())) {
-        block.ReThrow();
+    double doubleValue;
+    if (!v8Call(v8Value->NumberValue(dictionary.v8Context()), doubleValue))
         return false;
-    }
-    doubleToInteger(d, value);
+    doubleToInteger(doubleValue, value);
     return true;
 }
 
 template <>
 bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, RefPtrWillBeMember<DOMWindow>& value)
 {
     v8::Local<v8::Value> v8Value;
     if (!dictionary.get(key, v8Value))
         return false;
 
@@ skipping 55 matching lines @@
 {
     v8::Local<v8::Value> v8Value;
     if (!dictionary.get(key, v8Value))
         return false;
 
     if (!v8Value->IsArray())
         return false;
 
     v8::Local<v8::Array> v8Array = v8::Local<v8::Array>::Cast(v8Value);
     for (size_t i = 0; i < v8Array->Length(); ++i) {
-        v8::Local<v8::Value> indexedValue = v8Array->Get(v8::Uint32::New(dictionary.isolate(), i));
+        v8::Local<v8::Value> indexedValue;
+        if (!v8Array->Get(dictionary.v8Context(), v8::Uint32::New(dictionary.isolate(), i)).ToLocal(&indexedValue))
+            return false;
         TOSTRING_DEFAULT(V8StringResource<>, stringValue, indexedValue, false);
         value.append(stringValue);
     }
 
     return true;
 }
 
 template <>
 CORE_EXPORT bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, Vector<Vector<String>>& value, ExceptionState& exceptionState)
 {
     v8::Local<v8::Value> v8Value;
     if (!dictionary.get(key, v8Value))
         return false;
 
     if (!v8Value->IsArray())
         return false;
 
     v8::Local<v8::Array> v8Array = v8::Local<v8::Array>::Cast(v8Value);
     for (size_t i = 0; i < v8Array->Length(); ++i) {
-        v8::Local<v8::Value> v8IndexedValue = v8Array->Get(v8::Uint32::New(dictionary.isolate(), i));
+        v8::Local<v8::Value> v8IndexedValue;
+        if (!v8Array->Get(dictionary.v8Context(), v8::Uint32::New(dictionary.isolate(), i)).ToLocal(&v8IndexedValue))
+            return false;
         Vector<String> indexedValue = toImplArray<String>(v8IndexedValue, i, dictionary.isolate(), exceptionState);
         if (exceptionState.hadException())
             return false;
         value.append(indexedValue);
     }
 
     return true;
 }
 
 template <>
@@ skipping 199 matching lines @@
 
     value = toRefPtrWillBeMemberNativeArray<MessagePort, V8MessagePort>(v8Value, key, dictionary.isolate(), context.exceptionState());
 
     if (context.exceptionState().throwIfNeeded())
         return false;
 
     return true;
 }
 
 } // namespace blink