bindings: Use V8 MaybeLocal<> APIs in Dictionary class

Source/bindings/core/v8/Dictionary.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 28 matching lines @@
 #include "bindings/core/v8/V8Path2D.h"
 #include "bindings/core/v8/V8Storage.h"
 #include "bindings/core/v8/V8TextTrack.h"
 #include "bindings/core/v8/V8VoidCallback.h"
 #include "bindings/core/v8/V8Window.h"
 #include "core/html/track/TrackBase.h"
 #include "wtf/MathExtras.h"
 
 namespace blink {
 
+#define TO_OBJECT_WITH_CHECK(context, value, object)                     \
+{                                                                        \
+    v8::MaybeLocal<v8::Object> maybeObject = value->ToObject(m_context); \
+    if (maybeObject.IsEmpty())                                           \
+        return false;                                                    \
+    if (!maybeObject.ToLocal(&object))                                   \
+        return false;                                                    \
+}
+
 static ExceptionState& emptyExceptionState()
 {
     AtomicallyInitializedStaticReference(WTF::ThreadSpecific<NonThrowableExceptionState>, exceptionState, new ThreadSpecific<NonThrowableExceptionState>);
     return *exceptionState;
 }
 
 Dictionary::Dictionary()
     : m_isolate(0)
     , m_exceptionState(&emptyExceptionState())
 {
 }
 
 Dictionary::Dictionary(const v8::Handle<v8::Value>& options, v8::Isolate* isolate, ExceptionState& exceptionState)
     : m_options(options)
     , m_isolate(isolate)
     , m_exceptionState(&exceptionState)
 {
     ASSERT(m_isolate);
     ASSERT(m_exceptionState);
+    subscribeScriptStateDisposal();
 #if ENABLE(ASSERT)
     m_exceptionState->onStackObjectChecker().add(this);
 #endif
 }
 
 Dictionary::~Dictionary()
 {
+    unsubscribeScriptStateDisposal();
 #if ENABLE(ASSERT)
     if (m_exceptionState)
         m_exceptionState->onStackObjectChecker().remove(this);
 #endif
 }
 
 Dictionary& Dictionary::operator=(const Dictionary& optionsObject)
 {
+    unsubscribeScriptStateDisposal();
     m_options = optionsObject.m_options;
     m_isolate = optionsObject.m_isolate;
+    subscribeScriptStateDisposal();
 #if ENABLE(ASSERT)
     if (m_exceptionState)
         m_exceptionState->onStackObjectChecker().remove(this);
 #endif
     m_exceptionState = optionsObject.m_exceptionState;
 #if ENABLE(ASSERT)
     if (m_exceptionState)
         m_exceptionState->onStackObjectChecker().add(this);
 #endif
     return *this;
@@ skipping 13 matching lines @@
 {
     if (m_options.IsEmpty())
         return true;
     return blink::isUndefinedOrNull(m_options);
 }
 
 bool Dictionary::hasProperty(const String& key) const
 {
     if (isUndefinedOrNull())
         return false;
-    v8::Local<v8::Object> options = m_options->ToObject(m_isolate);
-    ASSERT(!options.IsEmpty());
+    v8::Local<v8::Object> object;
+    TO_OBJECT_WITH_CHECK(m_context, m_options, object);
 
     ASSERT(m_isolate);
     ASSERT(m_isolate == v8::Isolate::GetCurrent());
     ASSERT(m_exceptionState);
     v8::Handle<v8::String> v8Key = v8String(m_isolate, key);
-    if (!options->Has(v8Key))
+    if (v8Key.IsEmpty() || !object->Has(v8Key))

[bashi, 2015/03/03 04:25:05]

This seems redundant, but not sure we can omit IsEmpty() check.

         return false;
 
     return true;
 }
 
 bool Dictionary::getKey(const String& key, v8::Local<v8::Value>& value) const
 {
     if (isUndefinedOrNull())
         return false;
-    v8::Local<v8::Object> options = m_options->ToObject(m_isolate);
-    ASSERT(!options.IsEmpty());
+    v8::Local<v8::Object> object;
+    TO_OBJECT_WITH_CHECK(m_context, m_options, object);
 
     ASSERT(m_isolate);
     ASSERT(m_isolate == v8::Isolate::GetCurrent());
     ASSERT(m_exceptionState);
     v8::Handle<v8::String> v8Key = v8String(m_isolate, key);
-    if (!options->Has(v8Key))
+    if (v8Key.IsEmpty() || !object->Has(v8Key))
         return false;
-    value = options->Get(v8Key);
-    if (value.IsEmpty())
-        return false;
-    return true;
+    value = object->Get(v8Key);
+    return !value.IsEmpty();
 }
 
 bool Dictionary::get(const String& key, v8::Local<v8::Value>& value) const
 {
     return getKey(key, value);
 }
 
 bool Dictionary::get(const String& key, Dictionary& value) const
 {
     v8::Local<v8::Value> v8Value;
     if (!getKey(key, v8Value))
         return false;
 
     if (v8Value->IsObject()) {
         ASSERT(m_isolate);
         ASSERT(m_isolate == v8::Isolate::GetCurrent());
         value = Dictionary(v8Value, m_isolate, *m_exceptionState);
     }
 
     return true;
 }
 
 bool Dictionary::set(const String& key, const v8::Handle<v8::Value>& value)
 {
     if (isUndefinedOrNull())
         return false;
-    v8::Local<v8::Object> options = m_options->ToObject(m_isolate);
-    ASSERT(!options.IsEmpty());
+    v8::Local<v8::Object> object;
+    TO_OBJECT_WITH_CHECK(m_context, m_options, object);
     ASSERT(m_exceptionState);
 
-    return options->Set(v8String(m_isolate, key), value);
+    return object->Set(v8String(m_isolate, key), value);
 }
 
 bool Dictionary::set(const String& key, const String& value)
 {
     return set(key, v8String(m_isolate, value));
 }
 
 bool Dictionary::set(const String& key, unsigned value)
 {
     return set(key, v8::Integer::NewFromUnsigned(m_isolate, value));
@@ skipping 20 matching lines @@
 
     context.throwTypeError(ExceptionMessages::incorrectPropertyType(key, "does not have a Dictionary type."));
     return false;
 }
 
 bool Dictionary::getOwnPropertiesAsStringHashMap(HashMap<String, String>& hashMap) const
 {
     if (!isObject())
         return false;
 
-    v8::Handle<v8::Object> options = m_options->ToObject(m_isolate);
-    if (options.IsEmpty())
-        return false;
+    v8::Local<v8::Object> object;
+    TO_OBJECT_WITH_CHECK(m_context, m_options, object);
 
-    v8::Local<v8::Array> properties = options->GetOwnPropertyNames();
+    v8::Local<v8::Array> properties = object->GetOwnPropertyNames();
     if (properties.IsEmpty())
         return true;
     for (uint32_t i = 0; i < properties->Length(); ++i) {
-        v8::Local<v8::String> key = properties->Get(i)->ToString(m_isolate);
-        if (!options->Has(key))
+        v8::Local<v8::Value> property = properties->Get(i);
+        if (property.IsEmpty())
+            continue;
+        v8::MaybeLocal<v8::String> maybeKey = properties->Get(i)->ToString(m_context);
+        v8::Local<v8::String> key;
+        if (!maybeKey.ToLocal(&key) || !object->Has(key))
             continue;
 
-        v8::Local<v8::Value> value = options->Get(key);
+        v8::Local<v8::Value> value = object->Get(key);
+        if (value.IsEmpty())
+            continue;
         TOSTRING_DEFAULT(V8StringResource<>, stringKey, key, false);
         TOSTRING_DEFAULT(V8StringResource<>, stringValue, value, false);
         if (!static_cast<const String&>(stringKey).isEmpty())
             hashMap.set(stringKey, stringValue);
     }
 
     return true;
 }
 
 bool Dictionary::getPropertyNames(Vector<String>& names) const
 {
     if (!isObject())
         return false;
 
-    v8::Handle<v8::Object> options = m_options->ToObject(m_isolate);
-    if (options.IsEmpty())
-        return false;
+    v8::Local<v8::Object> object;
+    TO_OBJECT_WITH_CHECK(m_context, m_options, object);
 
-    v8::Local<v8::Array> properties = options->GetPropertyNames();
+    v8::Local<v8::Array> properties = object->GetPropertyNames();
     if (properties.IsEmpty())
         return true;
     for (uint32_t i = 0; i < properties->Length(); ++i) {
-        v8::Local<v8::String> key = properties->Get(i)->ToString(m_isolate);
-        if (!options->Has(key))
+        v8::Local<v8::Value> property = properties->Get(i);
+        if (property.IsEmpty())
+            continue;
+        v8::MaybeLocal<v8::String> maybeKey = properties->Get(i)->ToString(m_context);
+        v8::Local<v8::String> key;
+        if (!maybeKey.ToLocal(&key) || !object->Has(key))
             continue;
         TOSTRING_DEFAULT(V8StringResource<>, stringKey, key, false);
         names.append(stringKey);
     }
 
     return true;
 }
 
 void Dictionary::ConversionContext::resetPerPropertyContext()
 {
@@ skipping 12 matching lines @@
     m_propertyTypeName = typeName;
 
     return *this;
 }
 
 void Dictionary::ConversionContext::throwTypeError(const String& detail)
 {
     exceptionState().throwTypeError(detail);
 }
 
+void Dictionary::willDisposeScriptState(ScriptState*)
+{
+    m_context.Clear();
+}
+
+void Dictionary::subscribeScriptStateDisposal()
+{
+    if (m_isolate) {
+        ScriptState* scriptState = ScriptState::current(m_isolate);
+        scriptState->addObserver(this);
+        m_context = scriptState->context();
+        ASSERT(!m_context.IsEmpty());
+    }
+}
+
+void Dictionary::unsubscribeScriptStateDisposal()
+{
+    if (m_isolate) {
+        ScriptState* scriptState = ScriptState::current(m_isolate);
+        scriptState->removeObserver(this);
+    }
+}
+
 } // namespace blink