Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1225)

Issue 964513002: Check more file types for Win-style line endings in PRESUBMIT.py (Closed)

Created:
5 years, 10 months ago by earthdok
Modified:
5 years, 9 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check more file types for Win-style line endings in PRESUBMIT.py Adding *.gn, *.gyp, *.gypi, *.isolate. BUG=385395 R=phajdan.jr@chromium.org Committed: https://crrev.com/1b5e0ee8a43bc1cf0373d48cb992cef067e090a0 Cr-Commit-Position: refs/heads/master@{#319882}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
earthdok
5 years, 10 months ago (2015-02-26 18:09:14 UTC) #1
Paweł Hajdan Jr.
LGTM
5 years, 9 months ago (2015-02-27 19:40:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964513002/1
5 years, 9 months ago (2015-02-28 14:11:12 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/872)
5 years, 9 months ago (2015-02-28 14:16:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964513002/1
5 years, 9 months ago (2015-02-28 21:46:30 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/904)
5 years, 9 months ago (2015-02-28 21:50:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964513002/1
5 years, 9 months ago (2015-03-10 14:53:20 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 15:19:19 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 15:19:44 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b5e0ee8a43bc1cf0373d48cb992cef067e090a0
Cr-Commit-Position: refs/heads/master@{#319882}

Powered by Google App Engine
This is Rietveld 408576698