Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: components/policy/resources/policy_templates.json

Issue 964503002: Implemented ForceMaximizeBrowserWindowOnFirstRun policy, added unit test and browser test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed description Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/resources/policy_templates.json
diff --git a/components/policy/resources/policy_templates.json b/components/policy/resources/policy_templates.json
index ed4a6b0f2b0fc52f76a7175157f1c2c43b357a2c..954d0eb229bdcec52cbf98d76af776b7b455a2d8 100644
--- a/components/policy/resources/policy_templates.json
+++ b/components/policy/resources/policy_templates.json
@@ -123,7 +123,7 @@
# persistent IDs for all fields (but not for groups!) are needed. These are
# specified by the 'id' keys of each policy. NEVER CHANGE EXISTING IDs,
# because doing so would break the deployed wire format!
-# For your editing convenience: highest ID currently used: 289
+# For your editing convenience: highest ID currently used: 290
#
# Placeholders:
# The following placeholder strings are automatically substituted:
@@ -7132,6 +7132,21 @@
'desc': '''If this policy is set to false or not configured, <ph name="PRODUCT_OS_NAME">$2<ex>Google Chrome OS</ex></ph> will allow the user to shut down the device.
If this policy is set to true, <ph name="PRODUCT_OS_NAME">$2<ex>Google Chrome OS</ex></ph> will trigger a reboot when the user shuts down the device. <ph name="PRODUCT_OS_NAME">$2<ex>Google Chrome OS</ex></ph> replaces all occurrences of shutdown buttons in the UI by reboot buttons. If the user shuts down the device using the power button, it will not automatically reboot, even if the policy is enabled.''',
},
+ {
+ 'name': 'ForceMaximizeBrowserWindowOnFirstRun',
bartfab (slow) 2015/03/12 11:54:48 Nit: How about s/BrowserWindow//? It seems unneces
peletskyi 2015/03/18 13:28:13 Done.
+ 'type': 'main',
+ 'schema': { 'type': 'boolean' },
+ 'supported_on': ['chrome_os:41-'],
bartfab (slow) 2015/03/12 11:54:48 Nit: s/41/43/
peletskyi 2015/03/18 13:28:13 Done.
+ 'features': {
+ 'dynamic_refresh': False,
+ 'per_profile': True,
+ },
+ 'example_value': True,
+ 'id': 290,
+ 'caption': '''Maximize browser window on the first run''',
bartfab (slow) 2015/03/12 11:54:48 Nit 1: s/browser/the first browser/ Nit 2: s/the /
peletskyi 2015/03/18 13:28:13 Done.
+ 'desc': '''If this policy is set to true <ph name="PRODUCT_NAME">$1<ex>Google Chrome</ex></ph> will be launched in maximized mode on the first run or on each login in case of public sessions.
bartfab (slow) 2015/03/12 11:54:48 Nit 1: s/true/true,/ Nit 2: s/be launched in maxim
peletskyi 2015/03/18 13:28:13 Done.
+ If this policy is set to false or not configured <ph name="PRODUCT_NAME">$1<ex>Google Chrome</ex></ph> will be opened in default mode (maximized in case if screen width less than 1366 in case of first run or as in previous run).''',
bartfab (slow) 2015/03/12 11:54:48 Nit 1: s/configured/configured,/ Nit 2: I think yo
peletskyi 2015/03/18 13:28:13 Done.
+ },
],
'messages': {
# Messages that are not associated to any policies.

Powered by Google App Engine
This is Rietveld 408576698