Implemented ForceMaximizeBrowserWindowOnFirstRun policy, added unit test and browser test.

ash/wm/window_positioner_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/window_positioner.h"
 
 #include "ash/shell.h"
 #include "ash/shell/toplevel_window.h"
 #include "ash/test/ash_test_base.h"
+#include "ash/test/test_shell_delegate.h"
 #include "ash/wm/window_positioner.h"
 #include "ash/wm/window_state.h"
 #include "ui/aura/window_event_dispatcher.h"
 #include "ui/gfx/screen.h"
 #include "ui/views/widget/widget.h"
 #include "ui/views/widget/widget_delegate.h"
 
 namespace ash {
 
 typedef test::AshTestBase WindowPositionerTest;
@@ skipping 119 matching lines @@
   params.context = Shell::GetPrimaryRootWindow();
   widget->Init(params);
   widget->SetBounds(gfx::Rect(450,10, 100, 100));
   wm::GetWindowState(widget->GetNativeView())->set_minimum_visibility(true);
   widget->Show();
   // Make sure the bounds is adjusted to be inside the work area.
   EXPECT_EQ("390,10 100x100", widget->GetWindowBoundsInScreen().ToString());
   widget->CloseNow();
 }
 
+TEST_F(WindowPositionerTest, FirstRunMaximizeWindow) {

[bartfab (slow), 2015/03/12 11:54:44]

Nit: The test names do not make it clear what combination of conditions is
tested by each. I think you should tweak the test names a bit and also add short
comments that explain what is being tested.

[peletskyi, 2015/03/18 13:28:10]

Done.

+  UpdateDisplay("1900x720");
+  gfx::Rect bounds_in_out(0, 0, 320, 240);
+  ui::WindowShowState show_state_out = ui::SHOW_STATE_DEFAULT;
+
+  test::TestShellDelegate* d =

[bartfab (slow), 2015/03/12 11:54:44]

Nit: Avoid abbreviations like |d|. Better use |delegate|.

[peletskyi, 2015/03/18 13:28:09]

Done.

+      static_cast<test::TestShellDelegate*>(Shell::GetInstance()->delegate());
+  d->SetFirstTimeMaximized(true);
+
+  ash::WindowPositioner::GetBoundsAndShowStateForNewWindow(

[bartfab (slow), 2015/03/12 11:54:44]

Nit: s/ash:://

[peletskyi, 2015/03/18 13:28:10]

Done.

+      Shell::GetScreen(), NULL, false, ui::SHOW_STATE_DEFAULT, &bounds_in_out,

[bartfab (slow), 2015/03/12 11:54:44]

Nit: s/NULL/nullptr/

[peletskyi, 2015/03/18 13:28:10]

Done.

+      &show_state_out);
+
+  EXPECT_EQ(show_state_out, ui::SHOW_STATE_MAXIMIZED);
+}
+
+TEST_F(WindowPositionerTest, FirstRunMaximizeWindowHighResloution) {
+  // Set width of the screen wider than limit.

[bartfab (slow), 2015/03/12 11:54:44]

Nit: What limit?

[peletskyi, 2015/03/18 13:28:10]

Done.

+  const int kWidth = ash::WindowPositioner::GetForceMaximizedWidthLimit() + 100;

[bartfab (slow), 2015/03/12 11:54:44]

Nit 1: This is not really a constant if it is calculated based on a method's
return value, hence s/kWidth/width/.
Nit 2: s/ash:://

[peletskyi, 2015/03/18 13:28:09]

Done.

+  const std::string kResolution = std::to_string(kWidth) + "x300";  //"1466x300"

[bartfab (slow), 2015/03/12 11:54:44]

1: Nit: s/kResolution/resolution/ for the same reason as above.
2: Nit: #include <string>
3: std::to_string() is not allowed. You cannot use C++11 library functions.
4: Nit: s|//|// |

[peletskyi, 2015/03/18 13:28:10]

Done.

+  UpdateDisplay(kResolution);
+  gfx::Rect bounds_in_out(0, 0, 320, 240);  // random bounds

[bartfab (slow), 2015/03/12 11:54:44]

Nit: The bounds are "random" in all the tests. Why do you need to document it
here, but not in the other tests? I would just remove the comment.

+  ui::WindowShowState show_state_out = ui::SHOW_STATE_DEFAULT;
+
+  test::TestShellDelegate* d =

[bartfab (slow), 2015/03/12 11:54:44]

As above: s/d/delegate/

[peletskyi, 2015/03/18 13:28:09]

Done.

+      static_cast<test::TestShellDelegate*>(Shell::GetInstance()->delegate());
+  d->SetFirstTimeMaximized(true);
+
+  ash::WindowPositioner::GetBoundsAndShowStateForNewWindow(

[bartfab (slow), 2015/03/12 11:54:44]

Nit: s/ash:://

[peletskyi, 2015/03/18 13:28:10]

Done.

+      Shell::GetScreen(), NULL, false, ui::SHOW_STATE_DEFAULT, &bounds_in_out,

[bartfab (slow), 2015/03/12 11:54:44]

Nit: s/NULL/nullptr/

[peletskyi, 2015/03/18 13:28:10]

Done.

+      &show_state_out);
+
+  EXPECT_EQ(show_state_out, ui::SHOW_STATE_MAXIMIZED);
+}
+
+TEST_F(WindowPositionerTest, FirstRunMaximizeWindowLowResolution) {
+  // Set width of the screen narrower than limit.

[bartfab (slow), 2015/03/12 11:54:44]

Nit: What limit?

[peletskyi, 2015/03/18 13:28:10]

Done.

+  const int kWidth = ash::WindowPositioner::GetForceMaximizedWidthLimit() - 100;

[bartfab (slow), 2015/03/12 11:54:44]

Nit: As above: s/kWidth/width/

[peletskyi, 2015/03/18 13:28:09]

Done.

+  const std::string kResolution = std::to_string(kWidth) + "x300";  //"1266x300"

[bartfab (slow), 2015/03/12 11:54:44]

1: Nit: s/kResolution/resolution/
3: std::to_string() is not allowed. You cannot use C++11 library functions.
4: Nit: s|//|// |

[peletskyi, 2015/03/18 13:28:10]

Done.

+  UpdateDisplay(kResolution);
+  gfx::Rect bounds_in_out(0, 0, 320, 240);  // random bounds

[bartfab (slow), 2015/03/12 11:54:44]

Nit: As above, I think you can drop this comment.

+  ui::WindowShowState show_state_out = ui::SHOW_STATE_DEFAULT;
+
+  test::TestShellDelegate* d =

[bartfab (slow), 2015/03/12 11:54:44]

As above: s/d/delegate/

[peletskyi, 2015/03/18 13:28:10]

Done.

+      static_cast<test::TestShellDelegate*>(Shell::GetInstance()->delegate());
+  d->SetFirstTimeMaximized(true);
+
+  ash::WindowPositioner::GetBoundsAndShowStateForNewWindow(

[bartfab (slow), 2015/03/12 11:54:44]

Nit: s/ash:://

[peletskyi, 2015/03/18 13:28:09]

Done.

+      Shell::GetScreen(), NULL, false, ui::SHOW_STATE_DEFAULT, &bounds_in_out,

[bartfab (slow), 2015/03/12 11:54:44]

Nit: s/NULL/nullptr/

[peletskyi, 2015/03/18 13:28:10]

Done.

+      &show_state_out);
+
+  EXPECT_EQ(show_state_out, ui::SHOW_STATE_MAXIMIZED);
+}
+

[bartfab (slow), 2015/03/12 11:54:44]

You do not seem to have any test that verifies a subsequent windows (i.e. not
the first window on first login) are *not* affected by the policy.

[peletskyi, 2015/03/18 13:28:10]

Added to browser tests.

 }  // namespace