Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 964483002: Revert of ensure host compiler is always clang when cross compiling from linux (Closed)

Created:
5 years, 10 months ago by dcarney
Modified:
5 years, 10 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of ensure host compiler is always clang when cross compiling from linux (patchset #6 id:100001 of https://codereview.chromium.org/955393002/) Reason for revert: broke some things Original issue's description: > ensure host compiler is always clang when cross compiling from linux > > BUG= > > Committed: https://crrev.com/56039af476797accc238dcb24c7ab926899287a0 > Cr-Commit-Position: refs/heads/master@{#26881} TBR=machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/6517181c495505b187898da46e6312fa9604a896 Cr-Commit-Position: refs/heads/master@{#26882}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M build/standalone.gypi View 2 chunks +0 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dcarney
Created Revert of ensure host compiler is always clang when cross compiling from linux
5 years, 10 months ago (2015-02-26 14:42:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964483002/1
5 years, 10 months ago (2015-02-26 14:43:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-26 14:43:54 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 14:44:06 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6517181c495505b187898da46e6312fa9604a896
Cr-Commit-Position: refs/heads/master@{#26882}

Powered by Google App Engine
This is Rietveld 408576698