Issue 964463004: <webview>: Removed ResolveURL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 964463004: <webview>: Removed ResolveURL (Closed)

Created:
5 years, 9 months ago by Fady Samuel

Modified:
5 years, 9 months ago

Reviewers:
Xi Han

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

<webview>: Removed ResolveURL ResolveURL was more complex than it needed to be and it only worked for extensions. This CL moves that funcitonality to NavigateGuest, and expands its scope to WebUI. BUG=none Committed: https://crrev.com/c2fc6144ed227bf2d6bc7791c910a2d4f3c58418 Cr-Commit-Position: refs/heads/master@{#318281}

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -16 lines)			Patch
	M	extensions/browser/guest_view/web_view/web_view_guest.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	extensions/browser/guest_view/web_view/web_view_guest.cc	View		2 chunks	+4 lines, -13 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964463004/1

5 years, 9 months ago (2015-02-26 18:39:34 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-02-26 19:37:17 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c2fc6144ed227bf2d6bc7791c910a2d4f3c58418
Cr-Commit-Position: refs/heads/master@{#318281}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages