Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1507)

Unified Diff: chrome/browser/autofill/form_structure_browsertest.cc

Issue 964453004: Autofill: Disable autofill for fields outside of forms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: minimize diff Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/autofill/autofill_renderer_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/form_structure_browsertest.cc
diff --git a/chrome/browser/autofill/form_structure_browsertest.cc b/chrome/browser/autofill/form_structure_browsertest.cc
index 52bcb4dd10ae6d449214bd20ce2300a605fcce31..455325b50901241165de5d131b36056c6215b891 100644
--- a/chrome/browser/autofill/form_structure_browsertest.cc
+++ b/chrome/browser/autofill/form_structure_browsertest.cc
@@ -46,6 +46,16 @@ const base::FilePath& GetTestDataDir() {
}
const std::vector<base::FilePath> GetTestFiles() {
+ static const base::FilePath::CharType* const kFilesToSkip[] = {
+ FILE_PATH_LITERAL("bug_459132.html"),
+ FILE_PATH_LITERAL("bug_454366b.html"),
+ FILE_PATH_LITERAL("bug_454366.html"),
+ FILE_PATH_LITERAL("25_checkout_m_llbean.com.html"),
+ };
+ std::set<base::FilePath> set_of_files_to_skip;
+ for (size_t i = 0; i < arraysize(kFilesToSkip); ++i)
+ set_of_files_to_skip.insert(base::FilePath(kFilesToSkip[i]));
+
base::FilePath dir;
CHECK(PathService::Get(base::DIR_SOURCE_ROOT, &dir));
dir = dir.AppendASCII("chrome/test/data/autofill")
@@ -55,7 +65,8 @@ const std::vector<base::FilePath> GetTestFiles() {
std::vector<base::FilePath> files;
for (base::FilePath input_file = input_files.Next(); !input_file.empty();
input_file = input_files.Next()) {
- files.push_back(input_file);
+ if (!ContainsKey(set_of_files_to_skip, input_file.BaseName()))
+ files.push_back(input_file);
}
std::sort(files.begin(), files.end());
« no previous file with comments | « no previous file | chrome/renderer/autofill/autofill_renderer_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698