Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 964453004: Autofill: Disable autofill for fields outside of forms. (Closed)

Created:
5 years, 9 months ago by Lei Zhang
Modified:
5 years, 9 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Autofill: Disable autofill for fields outside of forms. BUG=462375 Committed: https://crrev.com/eb9e20d80c31c2842509e5213d4864eadf84baa1 Cr-Commit-Position: refs/heads/master@{#318406}

Patch Set 1 #

Patch Set 2 : minimize diff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -63 lines) Patch
M chrome/browser/autofill/form_structure_browsertest.cc View 2 chunks +12 lines, -1 line 0 comments Download
M chrome/renderer/autofill/autofill_renderer_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/autofill/form_autofill_browsertest.cc View 18 chunks +20 lines, -18 lines 0 comments Download
M components/autofill/content/renderer/form_cache.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/autofill/content/renderer/form_cache.cc View 1 2 chunks +0 lines, -39 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Lei Zhang
Looks like this merges cleanly to M42. I didn't add too many comment since it's ...
5 years, 9 months ago (2015-02-27 00:30:35 UTC) #2
Evan Stade
lgtm
5 years, 9 months ago (2015-02-27 00:32:40 UTC) #3
Lei Zhang
And surprisingly, it merges cleanly to M41. So here we go.
5 years, 9 months ago (2015-02-27 02:26:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964453004/10006
5 years, 9 months ago (2015-02-27 02:27:22 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:10006)
5 years, 9 months ago (2015-02-27 04:22:25 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/eb9e20d80c31c2842509e5213d4864eadf84baa1 Cr-Commit-Position: refs/heads/master@{#318406}
5 years, 9 months ago (2015-02-27 04:22:54 UTC) #8
Lei Zhang
5 years, 9 months ago (2015-03-02 22:36:50 UTC) #9
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:10006) has been created in
https://codereview.chromium.org/974613002/ by thestig@chromium.org.

The reason for reverting is: CL merged to M41/M42. Re-enabling on trunk..

Powered by Google App Engine
This is Rietveld 408576698