Upstream iOS autofill driver implementation

Upstream iOS autofill driver implementation

BUG=437508
Committed: https://crrev.com/c0cc6e3b5e1e994c09bfb6101fc15facc0c282ce
Cr-Commit-Position: refs/heads/master@{#318723}

[sdefresne, 2015-02-26 13:46:52]

sdefresne@chromium.org changed reviewers:
- eugenebut@chromium.org

[sdefresne, 2015-02-26 13:46:52]

Please take a look.

[Evan Stade, 2015-02-26 19:26:36]

estade@chromium.org changed reviewers:
+ jdonnelly@chromium.org

[Evan Stade, 2015-02-26 19:26:36]

I will provide an owner's review, but I think jdonnelly should be in charge of
the substantive review (he knows obj c and ios APIs and needs to absorb this
stuff anyway).

[sdefresne, 2015-02-26 19:28:22]

On 2015/02/26 19:26:36, Evan Stade wrote:
> I will provide an owner's review, but I think jdonnelly should be in charge of
> the substantive review (he knows obj c and ios APIs and needs to absorb this
> stuff anyway).

Should I add jdonnelly as an OWNERS for components/autofill/ios then?

[Evan Stade, 2015-02-26 19:31:56]

On 2015/02/26 19:28:22, sdefresne wrote:
> On 2015/02/26 19:26:36, Evan Stade wrote:
> > I will provide an owner's review, but I think jdonnelly should be in charge
of
> > the substantive review (he knows obj c and ios APIs and needs to absorb this
> > stuff anyway).
> 
> Should I add jdonnelly as an OWNERS for components/autofill/ios then?

Actually, you should probably add yourself as well as jdonnelly.

[sdefresne, 2015-02-26 20:18:49]

On 2015/02/26 19:31:56, Evan Stade wrote:
> On 2015/02/26 19:28:22, sdefresne wrote:
> > On 2015/02/26 19:26:36, Evan Stade wrote:
> > > I will provide an owner's review, but I think jdonnelly should be in
charge
> of
> > > the substantive review (he knows obj c and ios APIs and needs to absorb
this
> > > stuff anyway).
> > 
> > Should I add jdonnelly as an OWNERS for components/autofill/ios then?
> 
> Actually, you should probably add yourself as well as jdonnelly.

Well, I'm already OWNERS for //components, so I can always do the OWNERS review
in case of necessity for someone on the team, however, I'm not really familiar
with the autofill component ios code (I've only audited for upstreamability) and
don't really feel that I should be an OWNERS for it directly.

[Evan Stade, 2015-02-26 20:22:30]

On 2015/02/26 20:18:49, sdefresne wrote:
> On 2015/02/26 19:31:56, Evan Stade wrote:
> > On 2015/02/26 19:28:22, sdefresne wrote:
> > > On 2015/02/26 19:26:36, Evan Stade wrote:
> > > > I will provide an owner's review, but I think jdonnelly should be in
> charge
> > of
> > > > the substantive review (he knows obj c and ios APIs and needs to absorb
> this
> > > > stuff anyway).
> > > 
> > > Should I add jdonnelly as an OWNERS for components/autofill/ios then?
> > 
> > Actually, you should probably add yourself as well as jdonnelly.
> 
> Well, I'm already OWNERS for //components, so I can always do the OWNERS
review
> in case of necessity for someone on the team, however, I'm not really familiar
> with the autofill component ios code (I've only audited for upstreamability)
and
> don't really feel that I should be an OWNERS for it directly.

ok

[sdefresne, 2015-02-27 17:27:49]

jdonnelly: ping?

[Justin Donnelly, 2015-03-02 17:00:56]

lgtm

Sorry for the slow response, I was out Friday.

Regarding making me an owner, that tentatively makes sense. I don't think it's
certain that I'll be making big contributions to the Bling codebase long-term,
so it's possible that it might not make sense down the road.  But I hope to be
around long-term, so for now this sounds reasonable.

Also, I'm still coming up to speed on ObjC and the iOS APIs, so I may need to
lean on you from time to time, Sylvain.  If there were a big, complicated CL for
example.

[Justin Donnelly, 2015-03-02 17:05:33]

On 2015/03/02 17:00:56, Justin Donnelly wrote:
> lgtm
> 
> Sorry for the slow response, I was out Friday.
> 
> Regarding making me an owner, that tentatively makes sense. I don't think it's
> certain that I'll be making big contributions to the Bling codebase long-term,
> so it's possible that it might not make sense down the road.  But I hope to be
> around long-term, so for now this sounds reasonable.
> 
> Also, I'm still coming up to speed on ObjC and the iOS APIs, so I may need to
> lean on you from time to time, Sylvain.  If there were a big, complicated CL
for
> example.

Quick question. Do either of you know why Sylvain's responses show up in GMail
as coming from "reply@chromiumcodereview-hr.appspotmail.com via m3k" instead of
sdefresne? It makes it a bit difficult to see who's saying what.

[sdefresne, 2015-03-02 17:18:37]

On 2015/03/02 17:05:33, Justin Donnelly wrote:
> On 2015/03/02 17:00:56, Justin Donnelly wrote:
> > lgtm
> > 
> > Sorry for the slow response, I was out Friday.
> > 
> > Regarding making me an owner, that tentatively makes sense. I don't think
it's
> > certain that I'll be making big contributions to the Bling codebase
long-term,
> > so it's possible that it might not make sense down the road.  But I hope to
be
> > around long-term, so for now this sounds reasonable.
> > 
> > Also, I'm still coming up to speed on ObjC and the iOS APIs, so I may need
to
> > lean on you from time to time, Sylvain.  If there were a big, complicated CL
> for
> > example.
> 
> Quick question. Do either of you know why Sylvain's responses show up in GMail
> as coming from mailto:"reply@chromiumcodereview-hr.appspotmail.com via m3k"
instead of
> sdefresne? It makes it a bit difficult to see who's saying what.

There was some discussion on that topic on chromium-dev
(https://groups.google.com/a/chromium.org/d/msg/chromium-dev/5Nq0TJdicJg/G8fLL...).
I never opted in to such an option though, so I don't know why it came from
reply@ though.

[sdefresne, 2015-03-02 17:23:06]

On 2015/03/02 17:00:56, Justin Donnelly wrote:
> lgtm
> 
> Sorry for the slow response, I was out Friday.
> 
> Regarding making me an owner, that tentatively makes sense. I don't think it's
> certain that I'll be making big contributions to the Bling codebase long-term,
> so it's possible that it might not make sense down the road.  But I hope to be
> around long-term, so for now this sounds reasonable.
> 
> Also, I'm still coming up to speed on ObjC and the iOS APIs, so I may need to
> lean on you from time to time, Sylvain.  If there were a big, complicated CL
for
> example.

sounds good to me

[sdefresne, 2015-03-02 17:28:02]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2015-03-02 17:28:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/964443002/40001

[commit-bot: I haz the power, 2015-03-02 17:45:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-02 17:45:19]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sdefresne, 2015-03-02 17:48:03]

sdefresne@chromium.org changed reviewers:
+ droger@chromium.org

[sdefresne, 2015-03-02 17:48:03]

+droger for DEPS on ios/web/public (this has not changed but still confuse the
presubmit check).

[droger, 2015-03-02 17:50:06]

dependency on ios/web/public lgtm

[sdefresne, 2015-03-02 17:51:31]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2015-03-02 17:51:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/964443002/40001

[commit-bot: I haz the power, 2015-03-02 18:15:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-02 18:16:26]

Patchset 3 (id:??) landed as
https://crrev.com/c0cc6e3b5e1e994c09bfb6101fc15facc0c282ce
Cr-Commit-Position: refs/heads/master@{#318723}