Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 964403005: [telemetry] Move winring0 and ippet back outside AMD64. (Closed)

Created:
5 years, 9 months ago by dtu
Modified:
5 years, 9 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[telemetry] Move winring0 and ippet back outside AMD64. They're both cross-platform binaries/packages and not 64-bit specific. We're looking for them in the correct place, but they're located in the wrong place. Potential follow-ups: - We should use support_binaries to find these files. - We should have support_binaries be more aware of cross-platform binaries. BUG=None. TEST=None. Committed: https://crrev.com/bed42845e4208d6b8136f8d877830b97fd25b70f Cr-Commit-Position: refs/heads/master@{#318963}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-2 lines, -0 lines) Patch
D tools/telemetry/bin/win/AMD64/ippet.zip.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/telemetry/bin/win/AMD64/winring0.zip.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
A + tools/telemetry/bin/win/ippet.zip.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/bin/win/winring0.zip.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
dtu
5 years, 9 months ago (2015-03-03 00:07:19 UTC) #2
aiolos (Not reviewing)
On 2015/03/03 00:07:19, dtu wrote: lgtm
5 years, 9 months ago (2015-03-03 00:07:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964403005/1
5 years, 9 months ago (2015-03-03 00:08:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/28372)
5 years, 9 months ago (2015-03-03 00:16:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964403005/1
5 years, 9 months ago (2015-03-03 22:37:06 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 00:02:18 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 00:03:17 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bed42845e4208d6b8136f8d877830b97fd25b70f
Cr-Commit-Position: refs/heads/master@{#318963}

Powered by Google App Engine
This is Rietveld 408576698