Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: remoting/app_remoting_webapp.gyp

Issue 964403004: [Chromoting] Enable jscompile for AppRemoting's feedback_consent page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sync/merge Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/app_remoting_webapp_build.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/app_remoting_webapp.gyp
diff --git a/remoting/app_remoting_webapp.gyp b/remoting/app_remoting_webapp.gyp
index de11d0f80c44f93e3add93b72e53ce81d2459254..e179f1e7835c0a38ee460aecede3f55085657ced 100644
--- a/remoting/app_remoting_webapp.gyp
+++ b/remoting/app_remoting_webapp.gyp
@@ -62,6 +62,29 @@
'<@(remoting_webapp_js_proto_files)',
],
},
+ {
+ 'action_name': 'Verify >(ar_app_name) feedback_consent.html',
+ 'variables': {
+ 'success_stamp': '<(PRODUCT_DIR)/>(_target_name)_feedback_consent_jscompile.stamp',
+ },
+ 'inputs': [
+ '<@(ar_feedback_consent_js_files)',
+ '<@(remoting_webapp_js_proto_files)',
+ # Include zip as input so that this action is run after the build.
+ '<(zip_path)',
+ ],
+ 'outputs': [
+ '<(success_stamp)',
+ ],
+ 'action': [
+ 'python', '../third_party/closure_compiler/checker.py',
+ '--strict',
+ '--no-single-file',
+ '--success-stamp', '<(success_stamp)',
+ '<@(ar_feedback_consent_js_files)',
+ '<@(remoting_webapp_js_proto_files)',
+ ],
+ },
], # actions
}],
], # conditions
« no previous file with comments | « no previous file | remoting/app_remoting_webapp_build.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698