Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: remoting/app_remoting_webapp.gyp

Issue 964403004: [Chromoting] Enable jscompile for AppRemoting's feedback_consent page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sync/merge Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | remoting/app_remoting_webapp_build.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'includes': [ 6 'includes': [
7 '../remoting/remoting_locales.gypi', 7 '../remoting/remoting_locales.gypi',
8 '../remoting/app_remoting_webapp_build.gypi', 8 '../remoting/app_remoting_webapp_build.gypi',
9 ], 9 ],
10 10
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 ], 55 ],
56 'action': [ 56 'action': [
57 'python', '../third_party/closure_compiler/checker.py', 57 'python', '../third_party/closure_compiler/checker.py',
58 '--strict', 58 '--strict',
59 '--no-single-file', 59 '--no-single-file',
60 '--success-stamp', '<(success_stamp)', 60 '--success-stamp', '<(success_stamp)',
61 '<@(ar_background_js_files)', 61 '<@(ar_background_js_files)',
62 '<@(remoting_webapp_js_proto_files)', 62 '<@(remoting_webapp_js_proto_files)',
63 ], 63 ],
64 }, 64 },
65 {
66 'action_name': 'Verify >(ar_app_name) feedback_consent.html',
67 'variables': {
68 'success_stamp': '<(PRODUCT_DIR)/>(_target_name)_feedback_consent_ jscompile.stamp',
69 },
70 'inputs': [
71 '<@(ar_feedback_consent_js_files)',
72 '<@(remoting_webapp_js_proto_files)',
73 # Include zip as input so that this action is run after the build.
74 '<(zip_path)',
75 ],
76 'outputs': [
77 '<(success_stamp)',
78 ],
79 'action': [
80 'python', '../third_party/closure_compiler/checker.py',
81 '--strict',
82 '--no-single-file',
83 '--success-stamp', '<(success_stamp)',
84 '<@(ar_feedback_consent_js_files)',
85 '<@(remoting_webapp_js_proto_files)',
86 ],
87 },
65 ], # actions 88 ], # actions
66 }], 89 }],
67 ], # conditions 90 ], # conditions
68 }, 91 },
69 92
70 'targets': [ 93 'targets': [
71 { 94 {
72 # Sample AppRemoting app. 95 # Sample AppRemoting app.
73 'target_name': 'ar_sample_app', 96 'target_name': 'ar_sample_app',
74 'app_key': 'Sample_App', 97 'app_key': 'Sample_App',
75 'app_id': 'ljacajndfccfgnfohlgkdphmbnpkjflk', 98 'app_id': 'ljacajndfccfgnfohlgkdphmbnpkjflk',
76 'app_client_id': 'sample_client_id', 99 'app_client_id': 'sample_client_id',
77 'app_name': 'App Remoting Client', 100 'app_name': 'App Remoting Client',
78 'app_description': 'App Remoting client', 101 'app_description': 'App Remoting client',
79 'app_capabilities': ['GOOGLE_DRIVE'], 102 'app_capabilities': ['GOOGLE_DRIVE'],
80 }, 103 },
81 ], # end of targets 104 ], # end of targets
82 } 105 }
OLDNEW
« no previous file with comments | « no previous file | remoting/app_remoting_webapp_build.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698