Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 964403004: [Chromoting] Enable jscompile for AppRemoting's feedback_consent page. (Closed)

Created:
5 years, 9 months ago by garykac
Modified:
5 years, 9 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Enable jscompile for AppRemoting's feedback_consent page. The cl does 4 things: (1) Adds a list (in gyp) for the feedback_consent js files. (2) Uses build-html.py to build feedback_consent.html from a template. (3) Adds an action to run jscompile over the feedback_consent js files. (4) Fixes the errors/warnings reported by jscompile. BUG=463200 Committed: https://crrev.com/1f67ef5a86e2c1bb43818a3948c3b50adb2137ae Cr-Commit-Position: refs/heads/master@{#318822}

Patch Set 1 #

Patch Set 2 : Fix deps for build-html; Remove old html file #

Patch Set 3 : sync/merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -86 lines) Patch
M remoting/app_remoting_webapp.gyp View 1 chunk +23 lines, -0 lines 0 comments Download
M remoting/app_remoting_webapp_build.gypi View 1 2 chunks +23 lines, -0 lines 0 comments Download
M remoting/app_remoting_webapp_files.gypi View 2 chunks +17 lines, -2 lines 0 comments Download
D remoting/webapp/app_remoting/html/feedback_consent.html View 1 2 1 chunk +0 lines, -69 lines 0 comments Download
A + remoting/webapp/app_remoting/html/template_feedback_consent.html View 1 2 1 chunk +3 lines, -7 lines 0 comments Download
M remoting/webapp/app_remoting/js/feedback_consent.js View 5 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
garykac
5 years, 9 months ago (2015-03-02 23:50:18 UTC) #2
Jamie
LGTM, thanks!
5 years, 9 months ago (2015-03-02 23:55:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964403004/40001
5 years, 9 months ago (2015-03-03 00:38:16 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-03 02:59:42 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 03:00:35 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1f67ef5a86e2c1bb43818a3948c3b50adb2137ae
Cr-Commit-Position: refs/heads/master@{#318822}

Powered by Google App Engine
This is Rietveld 408576698