Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 964403002: Upstream BrowserState::GetStatePath() (Closed)

Created:
5 years, 9 months ago by sdefresne
Modified:
5 years, 9 months ago
Reviewers:
droger
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream BrowserState::GetStatePath() When using multiple BrowserState (think saving and incognito), each one has a different path to stored data on iOS. In order to avoid confusion with chrome Profile change the name of the method returning the path of a BrowserState to GetStatePath(). BUG=None Committed: https://crrev.com/2bbdeede75fc7dca57169673b21a0e3a79af2dfb Cr-Commit-Position: refs/heads/master@{#318690}

Patch Set 1 #

Patch Set 2 : Fix client code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M ios/chrome/browser/suggestions/suggestions_service_factory.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/browser_state.h View 1 chunk +3 lines, -1 line 0 comments Download
M ios/web/public/test/test_browser_state.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/test/test_browser_state.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sdefresne
PTAL
5 years, 9 months ago (2015-03-02 13:26:50 UTC) #2
droger
lgtm
5 years, 9 months ago (2015-03-02 14:20:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964403002/20001
5 years, 9 months ago (2015-03-02 14:21:57 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-02 14:24:32 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 14:25:28 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2bbdeede75fc7dca57169673b21a0e3a79af2dfb
Cr-Commit-Position: refs/heads/master@{#318690}

Powered by Google App Engine
This is Rietveld 408576698