Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 964363003: Completes the move of Android metrics file to "metrics". (Closed)

Created:
5 years, 9 months ago by Yaron
Modified:
5 years, 9 months ago
CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Completes the move of Android metrics file to "metrics". Follows: https://codereview.chromium.org/968943004/ https://chrome-internal-review.googlesource.com/#/c/203597/ BUG=428903 TBR=jbudorick Committed: https://crrev.com/47b26ee4d278b6c65e18955799ebcc09f0c07af6 Cr-Commit-Position: refs/heads/master@{#318891}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 1 1 chunk +1 line, -0 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/UmaUtils.java View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Yaron
5 years, 9 months ago (2015-03-02 15:19:38 UTC) #2
Alexei Svitkine (slow)
lgtm
5 years, 9 months ago (2015-03-02 16:27:35 UTC) #3
Yaron
tbr jbudorick for findbugs removal
5 years, 9 months ago (2015-03-03 15:06:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964363003/20001
5 years, 9 months ago (2015-03-03 15:08:16 UTC) #8
jbudorick
lgtm
5 years, 9 months ago (2015-03-03 15:48:38 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-03 16:36:10 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 16:37:37 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/47b26ee4d278b6c65e18955799ebcc09f0c07af6
Cr-Commit-Position: refs/heads/master@{#318891}

Powered by Google App Engine
This is Rietveld 408576698