Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 964363002: Oilpan: define shrink{Inline}VectorBackingInternal inline. (Closed)

Created:
5 years, 9 months ago by sof
Modified:
5 years, 9 months ago
Reviewers:
tkent, haraken
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: define shrink{Inline}VectorBackingInternal inline. Move the definition of these entry points to the their header file, increasing inlining opportunities. R=haraken,tkent BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191095

Patch Set 1 #

Patch Set 2 : platform export backingShrink() instead #

Patch Set 3 : explanatory comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M Source/platform/heap/Heap.h View 1 2 3 chunks +13 lines, -3 lines 0 comments Download
M Source/platform/heap/Heap.cpp View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tkent
lgtm
5 years, 9 months ago (2015-03-02 09:41:59 UTC) #2
haraken
LGTM, having a comment would be a worth.
5 years, 9 months ago (2015-03-02 09:42:55 UTC) #3
sof
On 2015/03/02 09:42:55, haraken wrote: > LGTM, having a comment would be a worth. Added ...
5 years, 9 months ago (2015-03-02 10:05:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964363002/40001
5 years, 9 months ago (2015-03-02 10:41:00 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 11:24:19 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191095

Powered by Google App Engine
This is Rietveld 408576698