Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 964343002: Fix a closure compiler error which is introduced in 968793002. (Closed)

Created:
5 years, 9 months ago by yawano
Modified:
5 years, 9 months ago
Reviewers:
hirono
CC:
chromium-reviews, vitalyp+closure_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a closure compiler error which is introduced in 968793002. BUG=462521 TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/file_manager/foreground/js/metadata/compiled_resources.gyp && ninja -C out/Default Committed: https://crrev.com/2a44c5999333e731e0ce69057c3017279bd4a1b4 Cr-Commit-Position: refs/heads/master@{#318661}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/file_manager/file_manager/foreground/js/metadata/compiled_resources.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
yawano
The previous CL (http://crrev.com/968793002) broke closure compiler build bot. PTAL. Thank you!
5 years, 9 months ago (2015-03-02 07:16:28 UTC) #2
hirono
lgtm!
5 years, 9 months ago (2015-03-02 07:21:01 UTC) #3
yawano
On 2015/03/02 07:21:01, hirono wrote: > lgtm! Thank you!
5 years, 9 months ago (2015-03-02 07:22:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964343002/1
5 years, 9 months ago (2015-03-02 07:23:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-02 07:55:02 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 07:55:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a44c5999333e731e0ce69057c3017279bd4a1b4
Cr-Commit-Position: refs/heads/master@{#318661}

Powered by Google App Engine
This is Rietveld 408576698