content/renderer/media/video_capture_message_filter.cc - Issue 964293002: VideoCaptureImpl & relatives small cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/video_capture_message_filter.cc

Issue 964293002: VideoCaptureImpl & relatives small cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reverted changes in VideoCaptureImpl::OnDelegateAdded() - client must be removed before StartCapure… Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/video_capture_message_filter.cc

diff --git a/content/renderer/media/video_capture_message_filter.cc b/content/renderer/media/video_capture_message_filter.cc

index dcdcc244922c356758a96bcbed87f0380d414e5a..80fd570a6a89e02ed29d0cfef2cd40ff4f0bda0d 100644

--- a/content/renderer/media/video_capture_message_filter.cc

+++ b/content/renderer/media/video_capture_message_filter.cc

@@ -77,10 +77,9 @@ void VideoCaptureMessageFilter::OnFilterAdded(IPC::Sender* sender) {

DVLOG(1) << "VideoCaptureMessageFilter::OnFilterAdded()";

sender_ = sender;

- for (Delegates::iterator it = pending_delegates_.begin();

- it != pending_delegates_.end(); it++) {

- it->second->OnDelegateAdded(it->first);

- delegates_[it->first] = it->second;

+ for (const auto& pending_delegate : pending_delegates_) {

+ pending_delegate.second->OnDelegateAdded(pending_delegate.first);

+ delegates_[pending_delegate.first] = pending_delegate.second;

}

pending_delegates_.clear();

}