Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Side by Side Diff: tools/clang/blink_gc_plugin/tests/traceimpl_omitted_trace.h

Issue 964273002: BlinkGCPlugin: Handle omitted trace() in intermediary classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use range-for. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef TRACEIMPL_DEPENDENT_SCOPE_H_ 5 #ifndef TRACEIMPL_OMITTED_TRACE_H_
6 #define TRACEIMPL_DEPENDENT_SCOPE_H_ 6 #define TRACEIMPL_OMITTED_TRACE_H_
7 7
8 #include "heap/stubs.h" 8 #include "heap/stubs.h"
9 9
10 namespace blink { 10 namespace blink {
11 11
12 class X : public GarbageCollected<X> { 12 class A : public GarbageCollected<A> {
13 public:
14 virtual void trace(Visitor*) {}
15 };
16
17 template <typename T>
18 class Base : public GarbageCollected<Base<T> > {
19 public: 13 public:
20 virtual void trace(Visitor* visitor) { traceImpl(visitor); } 14 virtual void trace(Visitor* visitor) { traceImpl(visitor); }
21 virtual void trace(InlinedGlobalMarkingVisitor visitor) { 15 virtual void trace(InlinedGlobalMarkingVisitor visitor) {
22 traceImpl(visitor); 16 traceImpl(visitor);
23 } 17 }
24 18
25 private: 19 private:
26 template <typename VisitorDispatcher> 20 template <typename VisitorDispatcher>
27 void traceImpl(VisitorDispatcher visitor) {} 21 void traceImpl(VisitorDispatcher visitor) {}
28 }; 22 };
29 23
30 template <typename T> 24 class B : public A {
31 class Derived : public Base<T> { 25 // trace() isn't necessary because we've got nothing to trace here.
26 };
27
28 class C : public B {
32 public: 29 public:
33 void trace(Visitor* visitor) override { traceImpl(visitor); } 30 void trace(Visitor* visitor) override { traceImpl(visitor); }
34 void trace(InlinedGlobalMarkingVisitor visitor) override { 31 void trace(InlinedGlobalMarkingVisitor visitor) override {
35 traceImpl(visitor);
36 }
37
38 private:
39 template <typename VisitorDispatcher>
40 void traceImpl(VisitorDispatcher visitor) {
41 Base<T>::trace(visitor);
42 }
43 };
44
45 template <typename T>
46 class DerivedMissingTrace : public Base<T> {
47 public:
48 void trace(Visitor* visitor) override { traceImpl(visitor); }
49 void trace(InlinedGlobalMarkingVisitor visitor) override {
50 traceImpl(visitor); 32 traceImpl(visitor);
51 } 33 }
52 34
53 private: 35 private:
54 template <typename VisitorDispatcher> 36 template <typename VisitorDispatcher>
55 void traceImpl(VisitorDispatcher visitor) { 37 void traceImpl(VisitorDispatcher visitor) {
56 // Missing Base<T>::trace(visitor). 38 // B::trace() is actually A::trace(), and in certain cases we only get
39 // limited information like "there is a function call that will be resolved
40 // to A::trace()". We still want to mark B as traced.
41 B::trace(visitor);
57 } 42 }
58 }; 43 };
59 44
60 } 45 }
61 46
62 #endif // TRACEIMPL_DEPENDENT_SCOPE_H_ 47 #endif // TRACEIMPL_OMITTED_TRACE_H_
OLDNEW
« no previous file with comments | « tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp ('k') | tools/clang/blink_gc_plugin/tests/traceimpl_omitted_trace.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698