Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/substitution_pattern.h

Issue 964203002: tools/gn: Fix errors found by Facebook's flint tool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix chromium-style plugin errors Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/standard_out.cc ('k') | tools/gn/target_generator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/substitution_pattern.h
diff --git a/tools/gn/substitution_pattern.h b/tools/gn/substitution_pattern.h
index a3d6f7e633400c524492f6c2fb682a303edd9ed9..76edf8cbb4b996d1052ec8653ae872f070be45f1 100644
--- a/tools/gn/substitution_pattern.h
+++ b/tools/gn/substitution_pattern.h
@@ -20,7 +20,7 @@ class SubstitutionPattern {
public:
struct Subrange {
Subrange();
- Subrange(SubstitutionType t, const std::string& l = std::string());
+ explicit Subrange(SubstitutionType t, const std::string& l = std::string());
~Subrange();
inline bool operator==(const Subrange& other) const {
« no previous file with comments | « tools/gn/standard_out.cc ('k') | tools/gn/target_generator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698