tools/gn/pattern.h - Issue 964203002: tools/gn: Fix errors found by Facebook's flint tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/pattern.h

Issue 964203002: tools/gn: Fix errors found by Facebook's flint tool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix chromium-style plugin errors Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/pattern.h

diff --git a/tools/gn/pattern.h b/tools/gn/pattern.h

index f5f432cc09a1a7cbdc6eaeffaff5bd7bc0500fc9..39895bfa9ba94908d57616ed2b576fb64e1865cf 100644

--- a/tools/gn/pattern.h

+++ b/tools/gn/pattern.h

@@ -19,7 +19,7 @@ class Pattern {

PATH_BOUNDARY // '/' or beginning of string.

};

- Subrange(Type t, const std::string& l = std::string())

+ explicit Subrange(Type t, const std::string& l = std::string())

: type(t),

literal(l) {

}

@@ -44,7 +44,7 @@ class Pattern {

std::string literal;

};

- Pattern(const std::string& s);

+ explicit Pattern(const std::string& s);

~Pattern();

// Returns true if the current pattern matches the given string.

« no previous file with comments | « tools/gn/parse_tree.h ('k') | tools/gn/scope.h » ('j') | no next file with comments »