tools/gn/config_values_extractors.cc - Issue 964203002: tools/gn: Fix errors found by Facebook's flint tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/config_values_extractors.cc

Issue 964203002: tools/gn: Fix errors found by Facebook's flint tool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix chromium-style plugin errors Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/config_values_extractors.cc

diff --git a/tools/gn/config_values_extractors.cc b/tools/gn/config_values_extractors.cc

index 646e2d7bb2e5384f38301afe89820fcee9d66992..18617db7970537b9cfa9000e82477852d1187aa1 100644

--- a/tools/gn/config_values_extractors.cc

+++ b/tools/gn/config_values_extractors.cc

@@ -10,7 +10,7 @@ namespace {

class EscapedStringWriter {

public:

- EscapedStringWriter(const EscapeOptions& escape_options)

+ explicit EscapedStringWriter(const EscapeOptions& escape_options)

: escape_options_(escape_options) {

}

« no previous file with comments | « tools/gn/commands.cc ('k') | tools/gn/copy_target_generator.h » ('j') | no next file with comments »