tools/gn/builder.h - Issue 964203002: tools/gn: Fix errors found by Facebook's flint tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/builder.h

Issue 964203002: tools/gn: Fix errors found by Facebook's flint tool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix chromium-style plugin errors Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/builder.h

diff --git a/tools/gn/builder.h b/tools/gn/builder.h

index 56aa6e4ce4bd3a4447861c71aaf1e101d5c6bc6d..ee47007485e8eccc6b36d5e28fb72bac6451c394 100644

--- a/tools/gn/builder.h

+++ b/tools/gn/builder.h

@@ -23,7 +23,7 @@ class Builder : public base::RefCountedThreadSafe<Builder> {

public:

typedef base::Callback<void(const BuilderRecord*)> ResolvedCallback;

- Builder(Loader* loader);

+ explicit Builder(Loader* loader);

// The resolved callback is called whenever a target has been resolved. This

// will be executed only on the main thread.

« no previous file with comments | « tools/gn/binary_target_generator.h ('k') | tools/gn/c_include_iterator.h » ('j') | no next file with comments »