tools/gn/tutorial/hello.cc - Issue 964203002: tools/gn: Fix errors found by Facebook's flint tool.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/gn/tutorial/hello.cc

Issue 964203002: tools/gn: Fix errors found by Facebook's flint tool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix chromium-style plugin errors Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

	5 #include "tools/gn/tutorial/hello.h"

	6

5 #include <stdio.h>	7 #include <stdio.h>

6	8

7 #include "tools/gn/tutorial/hello.h"

8

9 void Hello(const char* who) {	9 void Hello(const char* who) {

10 printf("Hello, %s.\n", who);	10 printf("Hello, %s.\n", who);

11 }	11 }

12	12

13 #if defined(TWO_PEOPLE)	13 #if defined(TWO_PEOPLE)

14 void Hello(const char* one, const char* two) {	14 void Hello(const char* one, const char* two) {

15 printf("Hello, %s and %s.\n", one, two);	15 printf("Hello, %s and %s.\n", one, two);

16 }	16 }

17 #endif	17 #endif

OLD	NEW

« no previous file with comments | « tools/gn/test_with_scope.h ('k') | tools/gn/unique_vector.h » ('j') | no next file with comments »