Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Side by Side Diff: tools/gn/binary_target_generator.h

Issue 964203002: tools/gn: Fix errors found by Facebook's flint tool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix chromium-style plugin errors Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/gn/action_target_generator.h ('k') | tools/gn/builder.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef TOOLS_GN_BINARY_TARGET_GENERATOR_H_ 5 #ifndef TOOLS_GN_BINARY_TARGET_GENERATOR_H_
6 #define TOOLS_GN_BINARY_TARGET_GENERATOR_H_ 6 #define TOOLS_GN_BINARY_TARGET_GENERATOR_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "tools/gn/target_generator.h" 9 #include "tools/gn/target_generator.h"
10 10
11 // Populates a Target with the values from a binary rule (executable, shared 11 // Populates a Target with the values from a binary rule (executable, shared
12 // library, or static library). 12 // library, or static library).
13 class BinaryTargetGenerator : public TargetGenerator { 13 class BinaryTargetGenerator : public TargetGenerator {
14 public: 14 public:
15 BinaryTargetGenerator(Target* target, 15 BinaryTargetGenerator(Target* target,
16 Scope* scope, 16 Scope* scope,
17 const FunctionCallNode* function_call, 17 const FunctionCallNode* function_call,
18 Target::OutputType type, 18 Target::OutputType type,
19 Err* err); 19 Err* err);
20 virtual ~BinaryTargetGenerator(); 20 ~BinaryTargetGenerator() override;
21 21
22 protected: 22 protected:
23 void DoRun() override; 23 void DoRun() override;
24 24
25 private: 25 private:
26 bool FillCompleteStaticLib(); 26 bool FillCompleteStaticLib();
27 bool FillOutputName(); 27 bool FillOutputName();
28 bool FillOutputExtension(); 28 bool FillOutputExtension();
29 bool FillAllowCircularIncludesFrom(); 29 bool FillAllowCircularIncludesFrom();
30 30
31 Target::OutputType output_type_; 31 Target::OutputType output_type_;
32 32
33 DISALLOW_COPY_AND_ASSIGN(BinaryTargetGenerator); 33 DISALLOW_COPY_AND_ASSIGN(BinaryTargetGenerator);
34 }; 34 };
35 35
36 #endif // TOOLS_GN_BINARY_TARGET_GENERATOR_H_ 36 #endif // TOOLS_GN_BINARY_TARGET_GENERATOR_H_
OLDNEW
« no previous file with comments | « tools/gn/action_target_generator.h ('k') | tools/gn/builder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698