Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 964193002: Cleanup/ Remove deprecated extension notification from ExtensionHost (Closed)

Created:
5 years, 9 months ago by limasdf
Modified:
5 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup/ Remove deprecated extension notification from ExtensionHost Remove deprecated extension notification from ExtensionHost. Use ExtensionRegistryObserver instead. BUG=411568 Committed: https://crrev.com/bbaa913d45afe123f2e256a48deaf58dbdb3181c Cr-Commit-Position: refs/heads/master@{#318803}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -45 lines) Patch
M chrome/browser/extensions/extension_view_host.h View 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_view_host.cc View 2 chunks +8 lines, -10 lines 0 comments Download
M extensions/browser/extension_host.h View 4 chunks +6 lines, -12 lines 0 comments Download
M extensions/browser/extension_host.cc View 4 chunks +13 lines, -22 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
limasdf
5 years, 9 months ago (2015-03-02 01:05:26 UTC) #3
not at google - send to devlin
lgtm, you rock.
5 years, 9 months ago (2015-03-02 17:42:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964193002/20001
5 years, 9 months ago (2015-03-02 22:52:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 9 months ago (2015-03-02 23:52:42 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 23:56:22 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bbaa913d45afe123f2e256a48deaf58dbdb3181c
Cr-Commit-Position: refs/heads/master@{#318803}

Powered by Google App Engine
This is Rietveld 408576698