Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 964173002: Oilpan: improve resource-tree-mimetype.html stability. (Closed)

Created:
5 years, 9 months ago by sof
Modified:
5 years, 9 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: improve resource-tree-mimetype.html stability. The http/tests/inspector-enabled/resource-tree/resource-tree-mimetype.html test enumerates the current set of registered resources, showing their properties. With Oilpan enabled, the registered resources might include ones which are no longer alive, but not yet finalized. So as to ensure a consistent resource baseline for the test, force a GC before initiating the test. R=haraken BUG=462935 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191061

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M LayoutTests/http/tests/inspector-enabled/resource-tree/resource-tree-mimetype.html View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
Please take a look. To get stable output from this test when not running in ...
5 years, 9 months ago (2015-03-01 16:13:12 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-01 16:31:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964173002/1
5 years, 9 months ago (2015-03-01 17:28:51 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-01 17:31:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191061

Powered by Google App Engine
This is Rietveld 408576698