Issue 964163004: IDL: All interface types are implicitly nullable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 964163004: IDL: All interface types are implicitly nullable (Closed)

Created:
5 years, 9 months ago by Jens Widell

Modified:
5 years, 9 months ago

Reviewers:
haraken, philipj_slow

CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

IDL: All interface types are implicitly nullable Previously, only the subset "wrapper types" were considered implicitly nullable. The wrapper types are all interface types except some that all are really also implicitly nullable. This affects nullable attributes and method arguments of the types Dictionary EventListener EventHandler NodeFilter SerializedScriptValue but since there are none currently, there are no code generation changes. BUG=249598 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191065

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Source/bindings/scripts/v8_types.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964163004/1

5 years, 9 months ago (2015-03-01 16:49:34 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-01 18:22:14 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191065

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages