Fix test for function declarations syntax error.

Fix test for function declarations syntax error.

Also fix parsing of declarations after case labels.

R=waldron.rick@gmail.com,rossberg@chromium.org
BUG=v8:3939
LOG=N

Committed: https://crrev.com/a8289230a3d3b7f66c7676915f3b56c8f5e0e9b7
Cr-Commit-Position: refs/heads/master@{#27189}

[Dmitry Lomov (no reviews), 2015-03-03 16:14:07]

PTAL

[arv (Not doing code reviews), 2015-03-03 16:16:01]

arv@chromium.org changed reviewers:
+ rossberg@chromium.org
- rossberg@chromium.orh

[arv (Not doing code reviews), 2015-03-03 16:17:31]

https://codereview.chromium.org/964063003/diff/1/test/mjsunit/harmony/block-l...
File test/mjsunit/harmony/block-let-declaration.js (right):

https://codereview.chromium.org/964063003/diff/1/test/mjsunit/harmony/block-l...
test/mjsunit/harmony/block-let-declaration.js:152: TestLocalThrows("function f()
{ if (true) function g() {} }", SyntaxError);
It would be nice if these were changed into test/message tests so that we could
validate the message and the location.

[Dmitry Lomov (no reviews), 2015-03-03 16:36:18]

https://codereview.chromium.org/964063003/diff/1/test/mjsunit/harmony/block-l...
File test/mjsunit/harmony/block-let-declaration.js (right):

https://codereview.chromium.org/964063003/diff/1/test/mjsunit/harmony/block-l...
test/mjsunit/harmony/block-let-declaration.js:152: TestLocalThrows("function f()
{ if (true) function g() {} }", SyntaxError);
On 2015/03/03 16:17:31, arv wrote:
> It would be nice if these were changed into test/message tests so that we
could
> validate the message and the location.

That would be awesome but unfortunately not practical at this time :(
Discussed offline how we can improve on that.

[rossberg, 2015-03-04 10:40:25]

lgtm

[rossberg, 2015-03-04 10:42:14]

https://codereview.chromium.org/964063003/diff/1/test/mjsunit/harmony/block-l...
File test/mjsunit/harmony/block-let-declaration.js (right):

https://codereview.chromium.org/964063003/diff/1/test/mjsunit/harmony/block-l...
test/mjsunit/harmony/block-let-declaration.js:156: TestLocalThrows("function f()
{ label: function g() {} }", SyntaxError);
Oh wait. Actually this one shouldn't be a syntax error (even though it currently
is).

https://codereview.chromium.org/964063003/diff/1/test/mjsunit/harmony/block-l...
test/mjsunit/harmony/block-let-declaration.js:158: TestLocalThrows("function f()
{ switch (true) { case true: function g() {} } }", SyntaxError);
Neither the last two.

[Dmitry Lomov (no reviews), 2015-03-13 14:33:20]

PTAL

https://codereview.chromium.org/964063003/diff/1/test/mjsunit/harmony/block-l...
File test/mjsunit/harmony/block-let-declaration.js (right):

https://codereview.chromium.org/964063003/diff/1/test/mjsunit/harmony/block-l...
test/mjsunit/harmony/block-let-declaration.js:156: TestLocalThrows("function f()
{ label: function g() {} }", SyntaxError);
On 2015/03/04 10:42:14, rossberg wrote:
> Oh wait. Actually this one shouldn't be a syntax error (even though it
currently
> is).

We can make it a syntax error since we are free to not implement B.3.2

[rossberg, 2015-03-13 14:38:32]

On 2015/03/13 14:33:20, Dmitry Lomov (chromium) wrote:
> PTAL
> 
>
https://codereview.chromium.org/964063003/diff/1/test/mjsunit/harmony/block-l...
> File test/mjsunit/harmony/block-let-declaration.js (right):
> 
>
https://codereview.chromium.org/964063003/diff/1/test/mjsunit/harmony/block-l...
> test/mjsunit/harmony/block-let-declaration.js:156: TestLocalThrows("function
f()
> { label: function g() {} }", SyntaxError);
> On 2015/03/04 10:42:14, rossberg wrote:
> > Oh wait. Actually this one shouldn't be a syntax error (even though it
> currently
> > is).
> 
> We can make it a syntax error since we are free to not implement B.3.2

LGTM. Do we have tests for sloppy mode as well?

[Dmitry Lomov (no reviews), 2015-03-13 16:37:31]

The CQ bit was checked by dslomov@chromium.org

[Dmitry Lomov (no reviews), 2015-03-13 16:37:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/964063003/#ps40001 (title:
"Rebase")

[commit-bot: I haz the power, 2015-03-13 16:37:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/964063003/40001

[commit-bot: I haz the power, 2015-03-13 16:57:32]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-13 16:57:42]

Patchset 3 (id:??) landed as
https://crrev.com/a8289230a3d3b7f66c7676915f3b56c8f5e0e9b7
Cr-Commit-Position: refs/heads/master@{#27189}

[arv (Not doing code reviews), 2015-03-19 18:53:48]

arv@chromium.org changed reviewers:
+ arv@chromium.org

[arv (Not doing code reviews), 2015-03-19 18:53:49]

Does this create the bindings in the right place? I don't see any updates to the
switch statement.