Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: tools/nanobench_flags.py

Issue 964053002: Add msaa runs to nanobench (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/nanobench_flags.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/nanobench_flags.py
diff --git a/tools/nanobench_flags.py b/tools/nanobench_flags.py
index 18668c9dc27cf8b34bfde41530b224155f513ac0..cb862a6c639df25258ae6acf8cd253e624cb0496 100755
--- a/tools/nanobench_flags.py
+++ b/tools/nanobench_flags.py
@@ -24,6 +24,18 @@ def get_args(bot):
args.extend(['--scales', '1.0', '1.1'])
+ config = ['565', '8888', 'gpu', 'nonrendering', 'angle', 'hwui']
+ # The S4 crashes and the NP produces a long error stream when we run with
+ # MSAA.
+ if ('GalaxyS4' not in bot and
+ 'NexusPlayer' not in bot):
+ if 'Android' in bot:
+ config.extend(['msaa4', 'nvprmsaa4'])
+ else:
+ config.extend(['msaa16', 'nvprmsaa16'])
+ args.append('--config')
+ args.extend(config)
+
if 'Valgrind' in bot:
# Don't care about Valgrind performance.
args.extend(['--loops', '1'])
@@ -42,6 +54,7 @@ def get_args(bot):
if match:
args.append('--match')
args.extend(match)
+
if ('GalaxyS3' in bot or
'GalaxyS4' in bot):
« no previous file with comments | « tools/nanobench_flags.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698