Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: sky/engine/core/rendering/RenderBox.cpp

Issue 964023002: Remove unused foregroundRect argument to RenderLayerClipper::calculateRects. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/rendering/RenderBox.cpp
diff --git a/sky/engine/core/rendering/RenderBox.cpp b/sky/engine/core/rendering/RenderBox.cpp
index 5148cd28ab5271cfb8ca8e2f1a33348847c8e86c..a1af5ab2a92c706423e971809046112a983411c4 100644
--- a/sky/engine/core/rendering/RenderBox.cpp
+++ b/sky/engine/core/rendering/RenderBox.cpp
@@ -687,10 +687,9 @@ bool RenderBox::hitTestLayer(RenderLayer* rootLayer, RenderLayer* containerLayer
}
LayoutRect layerBounds;
- // FIXME(sky): Remove foregroundRect. It's unused.
- ClipRect contentRect, foregroundRect;
+ ClipRect contentRect;
ClipRectsContext clipRectsContext(rootLayer, RootRelativeClipRects);
- layer()->clipper().calculateRects(clipRectsContext, localHitTestRect, layerBounds, contentRect, foregroundRect);
+ layer()->clipper().calculateRects(clipRectsContext, localHitTestRect, layerBounds, contentRect);
// Next we want to see if the mouse pos is inside the child RenderObjects of the layer.
if (contentRect.intersects(localHitTestLocation)) {
@@ -864,12 +863,10 @@ void RenderBox::paintLayerContents(GraphicsContext* context, const LayerPainting
LayerPaintingInfo localPaintingInfo(paintingInfo);
LayoutRect layerBounds;
- // FIXME(sky): Remove foregroundRect. It's unused.
- ClipRect contentRect, foregroundRect;
+ ClipRect contentRect;
ClipRectsContext clipRectsContext(localPaintingInfo.rootLayer, PaintingClipRects, localPaintingInfo.subPixelAccumulation);
layer()->clipper().calculateRects(clipRectsContext, localPaintingInfo.paintDirtyRect,
- layerBounds, contentRect, foregroundRect,
- &offsetFromRoot);
+ layerBounds, contentRect, &offsetFromRoot);
if (!layer()->intersectsDamageRect(layerBounds, contentRect.rect(), localPaintingInfo.rootLayer, &offsetFromRoot))
return;
« no previous file with comments | « no previous file | sky/engine/core/rendering/RenderLayerClipper.h » ('j') | sky/engine/core/rendering/RenderLayerClipper.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698