Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 964003002: Fix 32-bit x86 Linux build for GN uploads. (Closed)

Created:
5 years, 9 months ago by Dirk Pranke
Modified:
5 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix 32-bit x86 Linux build for GN uploads. The bots still use 'cpu_arch' to set the architecture, and the build file was keying off of build_cpu_arch to determine whether or not to enable NaCl, so things were failing. Updating the the code to 'current_cpu' fixes the problem correctly. TBR=brettw@chromium.org Committed: https://crrev.com/1c35162ea310ab09b3bb72fe1bfe95232db5d1a6 Cr-Commit-Position: refs/heads/master@{#318585}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/config/features.gni View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964003002/1
5 years, 9 months ago (2015-02-28 01:16:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-28 02:55:23 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-02-28 02:56:49 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c35162ea310ab09b3bb72fe1bfe95232db5d1a6
Cr-Commit-Position: refs/heads/master@{#318585}

Powered by Google App Engine
This is Rietveld 408576698