Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 963993002: Fix crashes on ICS. (Closed)

Created:
5 years, 9 months ago by newt (away)
Modified:
5 years, 9 months ago
Reviewers:
gone, Evan Stade
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crashes on ICS. We were using several APIs introduced after API level 14. Fix that. BUG=462802 R=estade@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/bbc424dd379ed9e75f133da50e313e814105a327

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java View 4 chunks +4 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
newt (away)
PTAL
5 years, 9 months ago (2015-02-28 00:48:40 UTC) #2
Evan Stade
thanks for fixing. lgtm If you're looking for the minimal patch to merge to M42, ...
5 years, 9 months ago (2015-02-28 00:50:03 UTC) #3
newt (away)
On 2015/02/28 00:50:03, Evan Stade wrote: > thanks for fixing. lgtm > > If you're ...
5 years, 9 months ago (2015-02-28 00:56:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963993002/1
5 years, 9 months ago (2015-02-28 01:04:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/63185) linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 9 months ago (2015-02-28 01:59:48 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bbc424dd379ed9e75f133da50e313e814105a327 Cr-Commit-Position: refs/heads/master@{#318731}
5 years, 9 months ago (2015-03-02 19:03:51 UTC) #9
newt (away)
5 years, 9 months ago (2015-03-02 19:03:59 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bbc424dd379ed9e75f133da50e313e814105a327 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698