XPS, DM: add SkDocument::CreateXPS

XPS, DM: add SkDocument::CreateXPS

-   SkDocument::CreateXPS() function added, returns NULL on non-Windows OS.

-   DM: (Windows only) an XPSSink is added, fails on non-Windows OS

-   DM: Common code for PDFSink::draw and XPSSink::draw are factored into
    draw_skdocument static function.

-   SkDocument_XPS (Windows only) implementation of SkDocument via
    SkXPSDevice.

-   SkDocument_XPS_None (non-Windows) returns NULL for
    SkDocument::CreateXPS().

-   gyp/xps.gyp refactored.

-   SkXPSDevice::drawTextOnPath removed (see http://crrev.com/925343003 )

-   SkXPSDevice::drawPath supports conics via SkAutoConicToQuads.

Committed: https://skia.googlesource.com/skia/+/47ef4d5d934bba86848aa238efab21f54a160c1a

[hal.canary, 2015-02-28 01:18:09]

Patchset #2 (id:20001) has been deleted

[hal.canary, 2015-02-28 01:18:17]

Patchset #2 (id:40001) has been deleted

[hal.canary, 2015-02-28 12:49:06]

Patchset #2 (id:60001) has been deleted

[hal.canary, 2015-02-28 13:16:16]

Patchset #5 (id:140001) has been deleted

[hal.canary, 2015-02-28 13:16:21]

Patchset #4 (id:120001) has been deleted

[hal.canary, 2015-02-28 13:16:28]

Patchset #3 (id:100001) has been deleted

[hal.canary, 2015-02-28 13:16:33]

Patchset #2 (id:80001) has been deleted

[hal.canary, 2015-02-28 13:16:38]

Patchset #1 (id:1) has been deleted

[hal.canary, 2015-02-28 14:15:12]

Patchset #1 (id:160001) has been deleted

[hal.canary, 2015-02-28 14:15:39]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2015-02-28 14:17:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/963953002/180001

[commit-bot: I haz the power, 2015-02-28 14:17:07]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-02-28 20:17 UTC

[commit-bot: I haz the power, 2015-02-28 14:17:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-28 14:17:13]

Presubmit check for 963953002-180001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of:
('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org',
'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com')

Presubmit checks took 1.3s to calculate.

[hal.canary, 2015-02-28 14:18:23]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2015-02-28 14:19:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/963953002/180001

[commit-bot: I haz the power, 2015-02-28 14:19:17]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-02-28 20:19 UTC

[hal.canary, 2015-02-28 14:19:28]

The CQ bit was unchecked by halcanary@google.com

[hal.canary, 2015-03-02 21:17:29]

halcanary@google.com changed reviewers:
+ bungeman@google.com, mtklein@google.com, reed@google.com

[hal.canary, 2015-03-02 21:17:30]

PTAL

reed@ for API
bungeman@ for XPS
mtklein@ for DM

[mtklein, 2015-03-02 21:27:09]

DM LGTM

[reed1, 2015-03-02 21:32:27]

somewhat tangential : can we move SkXPSDevice.h into src? (so its not public)

https://codereview.chromium.org/963953002/diff/210001/include/core/SkDocument.h
File include/core/SkDocument.h (right):

https://codereview.chromium.org/963953002/diff/210001/include/core/SkDocument...
include/core/SkDocument.h:66: #ifdef SK_SUPPORT_XPS
Why does this check need to be here? Can it not just be on the impl, and we
return NULL on platforms that don't have XPS?

[hal.canary, 2015-03-02 21:35:32]

On 2015/03/02 21:32:27, reed1 wrote:
> somewhat tangential : can we move SkXPSDevice.h into src? (so its not public)

I wrote this CL with that in mind.

>
https://codereview.chromium.org/963953002/diff/210001/include/core/SkDocument.h
> File include/core/SkDocument.h (right):
> 
>
https://codereview.chromium.org/963953002/diff/210001/include/core/SkDocument...
> include/core/SkDocument.h:66: #ifdef SK_SUPPORT_XPS
> Why does this check need to be here? Can it not just be on the impl, and we
> return NULL on platforms that don't have XPS?

We can do that, BUT I think the #ifdef is very clear about when this is expected
to work and not.

[reed1, 2015-03-02 21:41:33]

https://codereview.chromium.org/963953002/diff/210001/include/core/SkDocument.h
File include/core/SkDocument.h (right):

https://codereview.chromium.org/963953002/diff/210001/include/core/SkDocument...
include/core/SkDocument.h:66: #ifdef SK_SUPPORT_XPS
On 2015/03/02 21:32:27, reed1 wrote:
> Why does this check need to be here? Can it not just be on the impl, and we
> return NULL on platforms that don't have XPS?

As a factory, it is allowed to return NULL even on a windows machine, so I think
the caller always needs to check.

[bungeman-skia, 2015-03-02 22:39:12]

https://codereview.chromium.org/963953002/diff/250001/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/963953002/diff/250001/dm/DM.cpp#newcode239
dm/DM.cpp:239: SINK("xps", XPSSink);
Oh, the beautiful, silly alignment.

https://codereview.chromium.org/963953002/diff/250001/gyp/xps.gyp
File gyp/xps.gyp (right):

https://codereview.chromium.org/963953002/diff/250001/gyp/xps.gyp#newcode32
gyp/xps.gyp:32: 'defines': [ 'SK_SUPPORT_XPS', ],
I don't think this define is used anywhere anymore? In fact, I don't think this
has been used since GM bit the dust.

[hal.canary, 2015-03-02 23:08:25]

https://codereview.chromium.org/963953002/diff/210001/include/core/SkDocument.h
File include/core/SkDocument.h (right):

https://codereview.chromium.org/963953002/diff/210001/include/core/SkDocument...
include/core/SkDocument.h:66: #ifdef SK_SUPPORT_XPS
On 2015/03/02 21:41:32, reed1 wrote:
> On 2015/03/02 21:32:27, reed1 wrote:
> > Why does this check need to be here? Can it not just be on the impl, and we
> > return NULL on platforms that don't have XPS?
> 
> As a factory, it is allowed to return NULL even on a windows machine, so I
think
> the caller always needs to check.

Done.

https://codereview.chromium.org/963953002/diff/250001/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/963953002/diff/250001/dm/DM.cpp#newcode239
dm/DM.cpp:239: SINK("xps", XPSSink);
On 2015/03/02 22:39:12, bungeman1 wrote:
> Oh, the beautiful, silly alignment.

Done.

https://codereview.chromium.org/963953002/diff/250001/gyp/xps.gyp
File gyp/xps.gyp (right):

https://codereview.chromium.org/963953002/diff/250001/gyp/xps.gyp#newcode32
gyp/xps.gyp:32: 'defines': [ 'SK_SUPPORT_XPS', ],
On 2015/03/02 22:39:12, bungeman1 wrote:
> I don't think this define is used anywhere anymore? In fact, I don't think
this
> has been used since GM bit the dust.

Done.

[mtklein, 2015-03-02 23:13:41]

DM LEvenBetterTM

[bungeman-skia, 2015-03-02 23:15:43]

lgtm

[hal.canary, 2015-03-02 23:31:12]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2015-03-02 23:31:13]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/963953002/#ps270001
(title: " ")

[commit-bot: I haz the power, 2015-03-02 23:32:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/963953002/270001

[commit-bot: I haz the power, 2015-03-02 23:32:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-02 23:32:18]

Presubmit check for 963953002-270001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of:
('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org',
'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com')

[reed1, 2015-03-03 14:40:45]

lgtm

[reed1, 2015-03-03 14:40:54]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-03-03 14:41:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/963953002/270001

[commit-bot: I haz the power, 2015-03-03 14:43:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-03 14:43:06]

Try jobs failed on following builders:
  Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x...)
  Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x...)
  Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Cl...)

[hal.canary, 2015-03-03 15:56:35]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2015-03-03 15:56:35]

The patchset sent to the CQ was uploaded after l-g-t-m from bungeman@google.com,
mtklein@google.com, reed@google.com
Link to the patchset: https://codereview.chromium.org/963953002/#ps290001
(title: "2015-03-03 (Tuesday) 10:56:15 EST")

[commit-bot: I haz the power, 2015-03-03 15:57:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/963953002/290001

[commit-bot: I haz the power, 2015-03-03 15:57:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-03 15:57:19]

Presubmit check for 963953002-290001 failed and returned exit status 1.

Traceback (most recent call last):
  File "/b/infra_internal/commit_queue/verification/presubmit_shim.py", line 34,
in <module>
    sys.exit(presubmit_support.Main(argv))
AttributeError: 'module' object has no attribute 'Main'

[hal.canary, 2015-03-03 15:58:22]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2015-03-03 15:58:22]

The patchset sent to the CQ was uploaded after l-g-t-m from bungeman@google.com,
mtklein@google.com, reed@google.com
Link to the patchset: https://codereview.chromium.org/963953002/#ps310001
(title: "2015-03-03 (Tuesday) 10:58:01 EST")

[hal.canary, 2015-03-03 15:58:35]

The CQ bit was unchecked by halcanary@google.com

[hal.canary, 2015-03-03 16:07:50]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2015-03-03 16:08:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/963953002/310001

[commit-bot: I haz the power, 2015-03-03 16:26:05]

Committed patchset #8 (id:310001) as
https://skia.googlesource.com/skia/+/00d39bcbfc8394a9b48b86b04ab06ec19091fa43

[hal.canary, 2015-03-03 16:33:36]

A revert of this CL (patchset #8 id:310001) has been created in
https://codereview.chromium.org/978443002/ by halcanary@google.com.

The reason for reverting is: breaking iOS build..

[hal.canary, 2015-03-03 17:01:06]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2015-03-03 17:01:06]

The patchset sent to the CQ was uploaded after l-g-t-m from bungeman@google.com,
mtklein@google.com, reed@google.com
Link to the patchset: https://codereview.chromium.org/963953002/#ps330001
(title: "fix iOS compile")

[commit-bot: I haz the power, 2015-03-03 17:01:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/963953002/330001

[commit-bot: I haz the power, 2015-03-03 17:13:13]

Committed patchset #9 (id:330001) as
https://skia.googlesource.com/skia/+/47ef4d5d934bba86848aa238efab21f54a160c1a