Issue 9639003: Handle uncommon download verdict for safebrowsing download protection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9639003: Handle uncommon download verdict for safebrowsing download protection. (Closed)

Created:
8 years, 9 months ago by mattm

Modified:
8 years, 9 months ago

Reviewers:
asanka, noelutz, Randy Smith (Not in Mondays), noé

CC:
chromium-reviews, rdsmith+dwatch_chromium.org, asanka

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Handle uncommon download verdict for safebrowsing download protection. BUG=102540 TEST=DownloadProtectionServiceTest.CheckClientDownloadSuccess Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127116

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -7 lines)			Patch
M	chrome/browser/download/chrome_download_manager_delegate.cc	View	1	2 chunks	+14 lines, -4 lines	0 comments	Download
M	chrome/browser/safe_browsing/download_protection_service.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/safe_browsing/download_protection_service.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/safe_browsing/download_protection_service_unittest.cc	View		2 chunks	+19 lines, -1 line	0 comments	Download
M	chrome/common/safe_browsing/csd.proto	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

mattm

(depends on http://codereview.chromium.org/9621007/) I didn't think of a good way to do a full end-to-end ...

8 years, 9 months ago (2012-03-08 03:03:37 UTC) #1

Randy Smith (Not in Mondays)

I'd be happier if Asanka's eyes passed over the CDMD change. I don't think he'll ...

8 years, 9 months ago (2012-03-08 16:47:54 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mattm@chromium.org/9639003/7001

8 years, 9 months ago (2012-03-16 03:29:20 UTC) #5

Change committed as 127116