Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 963873002: [Slimming Paint] Adjust the paint rect for paintOffset when painting column rules. (Closed)

Created:
5 years, 9 months ago by chrishtr
Modified:
5 years, 9 months ago
CC:
blink-reviews, blink-reviews-paint_chromium.org, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[Slimming Paint] Adjust the paint rect for paintOffset when painting column rules. BUG=460198 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191036

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M Source/core/paint/MultiColumnSetPainter.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/paint/RenderDrawingRecorder.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/paint/RenderDrawingRecorder.cpp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
chrishtr
5 years, 9 months ago (2015-02-27 22:04:06 UTC) #2
chrishtr
Added a RenderDrawingRecorder constructor for LayoutRect.
5 years, 9 months ago (2015-02-27 22:10:07 UTC) #3
leviw_travelin_and_unemployed
LGTM.
5 years, 9 months ago (2015-02-27 22:10:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963873002/20001
5 years, 9 months ago (2015-02-27 22:12:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_dbg/builds/29916) android_blink_compile_rel on tryserver.blink (JOB_FAILED, ...
5 years, 9 months ago (2015-02-27 22:47:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963873002/40001
5 years, 9 months ago (2015-02-27 23:45:27 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-02-28 01:03:48 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191036

Powered by Google App Engine
This is Rietveld 408576698