Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 963773002: Clean up stale java in explicit bindings generator gypi (Closed)

Created:
5 years, 9 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 9 months ago
Reviewers:
jamesr, cjhopman
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up stale java in explicit bindings generator gypi This applies the same approach as r318190 to clean up stale generated java when any mojom dependencies have changed in gyp targets using mojom_bindings_generator_explicit.gypi. BUG=461622 R=jamesr@chromium.org Committed: https://crrev.com/7a8e7054cd6d3a8ce9a5891f021629de94d8ae86 Cr-Commit-Position: refs/heads/master@{#318554}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M third_party/mojo/mojom_bindings_generator_explicit.gypi View 3 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Ken Rockot(use gerrit already)
5 years, 9 months ago (2015-02-27 16:38:50 UTC) #1
Ken Rockot(use gerrit already)
+cjhopman for sanity check. This is similar to the other recent CL, just another source ...
5 years, 9 months ago (2015-02-27 17:16:36 UTC) #3
cjhopman
lgtm
5 years, 9 months ago (2015-02-27 23:03:55 UTC) #4
jamesr
lgtm
5 years, 9 months ago (2015-02-27 23:04:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963773002/1
5 years, 9 months ago (2015-02-27 23:07:18 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-28 00:06:06 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-02-28 00:06:55 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a8e7054cd6d3a8ce9a5891f021629de94d8ae86
Cr-Commit-Position: refs/heads/master@{#318554}

Powered by Google App Engine
This is Rietveld 408576698