Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 963743002: Remove the warning message to inspector for dpi/dcm values (Closed)

Created:
5 years, 9 months ago by riju_
Modified:
5 years, 9 months ago
CC:
blink-reviews, Yoav Weiss, blink-reviews-style_chromium.org, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove the warning message to inspector for dpi/dcm values remove reportMediaQueryWarningIfNeeded() remove addResolutionWarningMessageToConsole() BUG=461389 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191044

Patch Set 1 #

Patch Set 2 : style nit #

Patch Set 3 : layout test fix + nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -94 lines) Patch
M LayoutTests/inspector/console/console-log-media-query-warning.html View 1 2 2 chunks +1 line, -7 lines 0 comments Download
M LayoutTests/inspector/console/console-log-media-query-warning-expected.txt View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/CSSStyleSheet.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/MediaList.h View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/css/MediaList.cpp View 1 2 2 chunks +0 lines, -71 lines 0 comments Download
M Source/core/css/MediaQueryMatcher.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/StyleSheetContents.cpp View 1 2 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
riju_
5 years, 9 months ago (2015-02-27 14:48:12 UTC) #3
kenneth.christiansen
lgtm
5 years, 9 months ago (2015-02-27 15:01:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963743002/60001
5 years, 9 months ago (2015-02-28 18:52:22 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-02-28 18:52:26 UTC) #8
kenneth.r.christiansen
lgtm
5 years, 9 months ago (2015-02-28 20:38:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963743002/60001
5 years, 9 months ago (2015-02-28 21:59:33 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-01 00:53:29 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191044

Powered by Google App Engine
This is Rietveld 408576698