Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2696)

Unified Diff: Source/core/svg/SVGPatternElement.cpp

Issue 963733002: [svg2] Make 'width' and 'height' presentation attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: test fixes Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/SVGPatternElement.cpp
diff --git a/Source/core/svg/SVGPatternElement.cpp b/Source/core/svg/SVGPatternElement.cpp
index d6111487d1f246c2f9189238e354fe93cc412705..f4bcb0c87db66b1fd592f1dba0c18cb0b2eddad7 100644
--- a/Source/core/svg/SVGPatternElement.cpp
+++ b/Source/core/svg/SVGPatternElement.cpp
@@ -88,31 +88,6 @@ bool SVGPatternElement::isSupportedAttribute(const QualifiedName& attrName)
return supportedAttributes.contains<SVGAttributeHashTranslator>(attrName);
}
-bool SVGPatternElement::isPresentationAttribute(const QualifiedName& attrName) const
fs 2015/03/12 14:28:48 Could you do this "revert" in a separate CL?
Erik Dahlström (inactive) 2015/03/12 16:14:56 Sure, now https://codereview.chromium.org/10064930
-{
- if (attrName == SVGNames::xAttr || attrName == SVGNames::yAttr)
- return true;
- return SVGElement::isPresentationAttribute(attrName);
-}
-
-bool SVGPatternElement::isPresentationAttributeWithSVGDOM(const QualifiedName& attrName) const
-{
- if (attrName == SVGNames::xAttr || attrName == SVGNames::yAttr)
- return true;
- return SVGElement::isPresentationAttributeWithSVGDOM(attrName);
-}
-
-void SVGPatternElement::collectStyleForPresentationAttribute(const QualifiedName& name, const AtomicString& value, MutableStylePropertySet* style)
-{
- RefPtrWillBeRawPtr<SVGAnimatedPropertyBase> property = propertyFromAttribute(name);
- if (property == m_x)
- addSVGLengthPropertyToPresentationAttributeStyle(style, CSSPropertyX, *m_x->currentValue());
- else if (property == m_y)
- addSVGLengthPropertyToPresentationAttributeStyle(style, CSSPropertyY, *m_y->currentValue());
- else
- SVGElement::collectStyleForPresentationAttribute(name, value, style);
-}
-
void SVGPatternElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
{
parseAttributeNew(name, value);
@@ -128,17 +103,11 @@ void SVGPatternElement::svgAttributeChanged(const QualifiedName& attrName)
SVGElement::InvalidationGuard invalidationGuard(this);
if (attrName == SVGNames::xAttr
- || attrName == SVGNames::yAttr) {
- invalidateSVGPresentationAttributeStyle();
- setNeedsStyleRecalc(LocalStyleChange,
- StyleChangeReasonForTracing::fromAttribute(attrName));
- }
-
- if (attrName == SVGNames::xAttr
|| attrName == SVGNames::yAttr
|| attrName == SVGNames::widthAttr
- || attrName == SVGNames::heightAttr)
+ || attrName == SVGNames::heightAttr) {
updateRelativeLengthsInformation();
+ }
LayoutSVGResourceContainer* renderer = toLayoutSVGResourceContainer(this->layoutObject());
if (renderer)

Powered by Google App Engine
This is Rietveld 408576698