[svg2] Make 'width' and 'height' presentation attributes

Source/core/layout/svg/LayoutSVGImage.cpp

 /*
  * Copyright (C) 2006 Alexander Kellett <lypanov@kde.org>
  * Copyright (C) 2006 Apple Computer, Inc.
  * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2007, 2008, 2009 Rob Buis <buis@kde.org>
  * Copyright (C) 2009 Google, Inc.
  * Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
  * Copyright (C) 2010 Patrick Gansterer <paroga@paroga.com>
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 74 matching lines @@
     // will return the underlying SVGImage.
     return !image->isSVGImage() || image != cachedImage.imageForRenderer(renderer);
 }
 
 bool LayoutSVGImage::updateImageViewport()
 {
     SVGImageElement* image = toSVGImageElement(element());
     FloatRect oldBoundaries = m_objectBoundingBox;
 
     SVGLengthContext lengthContext(image);
-    m_objectBoundingBox = FloatRect(image->x()->currentValue()->value(lengthContext), image->y()->currentValue()->value(lengthContext), image->width()->currentValue()->value(lengthContext), image->height()->currentValue()->value(lengthContext));
+    const LayoutStyle& style = image->layoutObject()->styleRef();

[fs, 2015/03/12 14:28:48]

image->layoutObject()->styleRef() => styleRef()

[Erik Dahlström (inactive), 2015/03/12 16:14:56]

Done.

+    m_objectBoundingBox = FloatRect(
+        lengthContext.valueForLength(style.svgStyle().x(), style, SVGLengthMode::Width),
+        lengthContext.valueForLength(style.svgStyle().y(), style, SVGLengthMode::Height),
+        lengthContext.valueForLength(style.width(), style, SVGLengthMode::Width),
+        lengthContext.valueForLength(style.height(), style, SVGLengthMode::Height));

[fs, 2015/03/12 14:28:48]

Almost looks like

style.svgStyle().x(), style.svgStyle().y(), style.width(), style.height() =>
FloatRect

will be a recurring pattern, so maybe (as a followup) make SVGLengthContext do
that.

[Erik Dahlström (inactive), 2015/03/12 16:14:56]

np, I'll do that as a followup.

     bool boundsChanged = oldBoundaries != m_objectBoundingBox;
 
     bool updatedViewport = false;
     ImageResource* cachedImage = m_imageResource->cachedImage();
     if (cachedImage && cachedImage->usesImageContainerSize()) {
         FloatSize imageViewportSize = computeImageViewportSize(*cachedImage);
-        if (LayoutSize(imageViewportSize) != m_imageResource->imageSize(style()->effectiveZoom())
+        if (LayoutSize(imageViewportSize) != m_imageResource->imageSize(style.effectiveZoom())
             || !containerSizeIsSetForRenderer(*cachedImage, this)) {
             m_imageResource->setContainerSizeForRenderer(roundedIntSize(imageViewportSize));
             updatedViewport = true;
         }
     }
 
     m_needsBoundariesUpdate |= boundsChanged;
     return updatedViewport || boundsChanged;
 }
 
@@ skipping 80 matching lines @@
 
 void LayoutSVGImage::addFocusRingRects(Vector<LayoutRect>& rects, const LayoutPoint&) const
 {
     // this is called from paint() after the localTransform has already been applied
     LayoutRect contentRect = LayoutRect(paintInvalidationRectInLocalCoordinates());
     if (!contentRect.isEmpty())
         rects.append(contentRect);
 }
 
 } // namespace blink