Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 963713003: Support --origin in android_mojo_shell. (Closed)

Created:
5 years, 9 months ago by ppi
Modified:
5 years, 9 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, blundell
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Support --origin in android_mojo_shell. This adds support for the --origin shell parameter in the android wrapper (android_mojo_shell.py), allowing to run apps from the cloud, e.g. mojo/tools/android_mojo_shell.py --release --origin=https://apps.domokit.org/android-arm/ mojo:spinning_cube R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/70ba66ca3808b4f7538034d383eb165349359cfa

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Ben's comments. #

Patch Set 3 : Address Ben's comments. #

Total comments: 2

Patch Set 4 : Move atexit.register(StopShell) to StartShell. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -17 lines) Patch
M mojo/tools/android_mojo_shell.py View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M mojo/tools/apptest_runner.py View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M mojo/tools/mopy/android.py View 1 2 3 2 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ppi
Hi Ben, ptal.
5 years, 9 months ago (2015-03-04 12:27:33 UTC) #1
qsr
https://codereview.chromium.org/963713003/diff/1/mojo/tools/android_mojo_shell.py File mojo/tools/android_mojo_shell.py (right): https://codereview.chromium.org/963713003/diff/1/mojo/tools/android_mojo_shell.py#newcode56 mojo/tools/android_mojo_shell.py:56: args.append(android.PrepareShellRun(config)) PrepareShellRun is doing more than just adding the ...
5 years, 9 months ago (2015-03-04 12:41:48 UTC) #2
ppi
Thanks, Ben. Ptal. https://codereview.chromium.org/963713003/diff/1/mojo/tools/android_mojo_shell.py File mojo/tools/android_mojo_shell.py (right): https://codereview.chromium.org/963713003/diff/1/mojo/tools/android_mojo_shell.py#newcode56 mojo/tools/android_mojo_shell.py:56: args.append(android.PrepareShellRun(config)) On 2015/03/04 12:41:48, qsr wrote: ...
5 years, 9 months ago (2015-03-04 12:55:43 UTC) #3
ppi
Made some changes as per our discussion off-bug. Ptal.
5 years, 9 months ago (2015-03-04 13:34:53 UTC) #4
qsr
https://codereview.chromium.org/963713003/diff/40001/mojo/tools/android_mojo_shell.py File mojo/tools/android_mojo_shell.py (right): https://codereview.chromium.org/963713003/diff/40001/mojo/tools/android_mojo_shell.py#newcode57 mojo/tools/android_mojo_shell.py:57: atexit.register(android.StopShell) This should be in either prepare shell or ...
5 years, 9 months ago (2015-03-04 13:49:53 UTC) #5
ppi
https://codereview.chromium.org/963713003/diff/40001/mojo/tools/android_mojo_shell.py File mojo/tools/android_mojo_shell.py (right): https://codereview.chromium.org/963713003/diff/40001/mojo/tools/android_mojo_shell.py#newcode57 mojo/tools/android_mojo_shell.py:57: atexit.register(android.StopShell) On 2015/03/04 13:49:52, qsr wrote: > This should ...
5 years, 9 months ago (2015-03-04 13:51:43 UTC) #6
qsr
lgtm
5 years, 9 months ago (2015-03-04 13:55:30 UTC) #7
ppi
5 years, 9 months ago (2015-03-04 14:16:07 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
70ba66ca3808b4f7538034d383eb165349359cfa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698