Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 963713002: [turbofan] Avoid generating dead BooleanNot nodes in typed lowering. (Closed)

Created:
5 years, 9 months ago by Benedikt Meurer
Modified:
5 years, 9 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Avoid generating dead BooleanNot nodes in typed lowering. Without this shortcut we generate one BooleanNot per JSUnaryNot with number input, which is quite common in asm.js. These dead nodes then survive until the late control reducer runs, and may prevent optimizations in the mean time. R=dcarney@chromium.org Committed: https://crrev.com/936ae2b81499d04c66fa6df5938fde4e56db6fe3 Cr-Commit-Position: refs/heads/master@{#26911}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 9 months ago (2015-02-27 10:02:46 UTC) #1
Benedikt Meurer
PTAL
5 years, 9 months ago (2015-02-27 10:02:58 UTC) #2
dcarney
lgtm
5 years, 9 months ago (2015-02-27 10:03:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963713002/1
5 years, 9 months ago (2015-02-27 10:04:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-27 10:25:01 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 10:25:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/936ae2b81499d04c66fa6df5938fde4e56db6fe3
Cr-Commit-Position: refs/heads/master@{#26911}

Powered by Google App Engine
This is Rietveld 408576698