Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 963683003: Enable on iOS all components unittests for components that are built (Closed)

Created:
5 years, 9 months ago by sdefresne
Modified:
5 years, 9 months ago
Reviewers:
blundell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable on iOS all components unittests for components that are built Update the list of included unit tests on iOS to list all the components that are built on iOS (based on the list in components/components.gyp). Use an exclusion to remove all tests that depends on //content. Sort the list of gypi files included by components.gyp. BUG=462585 Committed: https://crrev.com/9cd1247fd8512129c4fd489dcc264abe952810dc Cr-Commit-Position: refs/heads/master@{#318701}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Patch Set 3 : Revert changes to components/components.gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -7 lines) Patch
M components/components_tests.gyp View 1 1 chunk +51 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sdefresne
This one should be non-controversial. It enable roughly 500 tests for components we build on ...
5 years, 9 months ago (2015-02-27 16:04:38 UTC) #2
blundell
lgtm https://codereview.chromium.org/963683003/diff/1/components/components_tests.gyp File components/components_tests.gyp (right): https://codereview.chromium.org/963683003/diff/1/components/components_tests.gyp#newcode538 components/components_tests.gyp:538: # The include the test runner. s/The// https://codereview.chromium.org/963683003/diff/1/components/components_tests.gyp#newcode560 ...
5 years, 9 months ago (2015-03-02 10:52:05 UTC) #3
sdefresne
https://codereview.chromium.org/963683003/diff/1/components/components_tests.gyp File components/components_tests.gyp (right): https://codereview.chromium.org/963683003/diff/1/components/components_tests.gyp#newcode538 components/components_tests.gyp:538: # The include the test runner. On 2015/03/02 10:52:05, ...
5 years, 9 months ago (2015-03-02 15:13:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963683003/40001
5 years, 9 months ago (2015-03-02 15:17:39 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-02 15:56:59 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 15:57:36 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9cd1247fd8512129c4fd489dcc264abe952810dc
Cr-Commit-Position: refs/heads/master@{#318701}

Powered by Google App Engine
This is Rietveld 408576698