Source/modules/background_sync/SyncManager.idl - Issue 963683002: Add IDL and initial Blink API for Background Sync

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/background_sync/SyncManager.idl

Issue 963683002: Add IDL and initial Blink API for Background Sync (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Remembering how ASCII works Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/modules/background_sync/SyncManager.cpp ('K') | « Source/modules/background_sync/SyncManager.cpp ('k') | Source/modules/background_sync/SyncRegistration.h » ('j') | Source/modules/background_sync/SyncRegistration.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 [	5 [

6 Conditional=FOO,	6 Exposed=(Window),
	jkarlin 2015/02/27 20:08:13 Add ServiceWorker as well, or a FIXME to do so Add ServiceWorker as well, or a FIXME to do so iclelland 2015/03/02 03:51:12 Done. Added FIXME until I add the additional IPC f Show quoted text On 2015/02/27 20:08:13, jkarlin wrote: > Add ServiceWorker as well, or a FIXME to do so Done. Added FIXME until I add the additional IPC for the SW side
	7 GarbageCollected,

	8 RuntimeEnabled=BackgroundSync,

7 TypeChecking=Interface,	9 TypeChecking=Interface,

8 ] partial interface TestInterface3 {	10 ] interface SyncManager {

9 [Conditional=BAR, TypeChecking=Unrestricted] static void voidMethodDocument( Document document, double d);	11 [CallWith=ScriptState,ImplementedAs=registerFunction] Promise<SyncRegistrati on> register(SyncRegistrationOptions options);
	jkarlin 2015/02/27 20:08:13 Why registerFunction instead of register? Why registerFunction instead of register? jkarlin 2015/02/27 20:08:13 I believe you need to add 'optional' keyword befor I believe you need to add 'optional' keyword before SyncRegistrationOptions http://heycam.github.io/webidl/#dfn-optional-argument-default-value iclelland 2015/03/02 03:51:12 register's a c++ reserved keyword Show quoted text On 2015/02/27 20:08:13, jkarlin wrote: > Why registerFunction instead of register? register's a c++ reserved keyword
	12 [CallWith=ScriptState] Promise<sequence<SyncRegistration>> getRegistrations( );

	13 readonly attribute unsigned long minAllowablePeriod;

10 };	14 };

OLD	NEW