Add IDL and initial Blink API for Background Sync

Source/modules/background_sync/SyncManager.cpp

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "config.h"
+#include "modules/background_sync/SyncManager.h"
+
+#include "bindings/core/v8/CallbackPromiseAdapter.h"
+#include "bindings/core/v8/ScriptPromise.h"
+#include "bindings/core/v8/ScriptPromiseResolver.h"
+#include "bindings/core/v8/ScriptState.h"
+#include "core/dom/DOMException.h"
+#include "core/dom/Document.h"
+#include "core/dom/ExceptionCode.h"
+#include "core/dom/ExecutionContext.h"
+#include "modules/background_sync/SyncRegistrationCallbacks.h"
+#include "modules/background_sync/SyncRegistrationOptions.h"
+#include "modules/serviceworkers/ServiceWorkerRegistration.h"
+#include "public/platform/Platform.h"
+#include "public/platform/modules/background_sync/WebSyncProvider.h"
+#include "wtf/RefPtr.h"
+
+
+namespace blink {
+namespace {
+
+WebSyncProvider* backgroundSyncProvider()

[jkarlin, 2015/02/27 20:08:13]

contents of nested namespaces in blink are indented 4 spaces

[iclelland, 2015/03/02 03:51:11]

Done.

+{
+    WebSyncProvider* webSyncProvider = Platform::current()->backgroundSyncProvider();
+    ASSERT(webSyncProvider);
+    return webSyncProvider;
+}
+
+} // namespace

[jkarlin, 2015/02/27 20:08:12]

don't need the '// namespace' as this is such a short namespace

[iclelland, 2015/03/02 03:51:11]

Done.

+
+unsigned long SyncManager::minAllowablePeriod()
+{
+    return m_minAllowablePeriod;

[jkarlin, 2015/02/27 20:08:13]

return a constant defined in the unnamed namespace

[iclelland, 2015/03/02 03:51:11]

Done.

+}
+
+ScriptPromise SyncManager::registerFunction(blink::ScriptState* scriptState)

[jkarlin, 2015/02/27 20:08:12]

I don't think you need this method

[iclelland, 2015/03/02 03:51:11]

No, actually, I don't think we do. I was told earlier that calling .register()
-- with no options at all -- was distinct from .register(null) or
.register(options), and in the first case, this method would be called instead.

Tracing through execution, though, I've never been able to trigger it.

+{
+    RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+    ScriptPromise promise = resolver->promise();
+
+    backgroundSyncProvider()->registerBackgroundSync(0, new SyncRegistrationCallbacks(resolver, m_registration));
+
+    return promise;
+}
+
+ScriptPromise SyncManager::registerFunction(blink::ScriptState* scriptState, const SyncRegistrationOptions& options)
+{
+    RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+    ScriptPromise promise = resolver->promise();
+
+    backgroundSyncProvider()->registerBackgroundSync(0, new SyncRegistrationCallbacks(resolver, m_registration));

[jkarlin, 2015/02/27 20:08:12]

Please see PushManager::subscribe. They have a check for a detached window.
What's that about? Also, why do they have the separate PushController for
registering from the document vs serviceworker? Do we need to do the same here?

Ah, I see in the idl that this is Window only. I think we're going to wind up
adding ServiceWorker as well here. 

[iclelland, 2015/03/02 03:51:11]

Right -- I thought that one of the concerns was that a sync event can't trigger
the registration of another event, and that was why we removed register's
visibility from the service worker.

+
+    return promise;
+}
+
+ScriptPromise SyncManager::getRegistrations(blink::ScriptState* scriptState)
+{
+    RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+    ScriptPromise promise = resolver->promise();
+
+    // Don't have anything useful to do ATM
+    resolver->reject(DOMException::create(InvalidStateError, "Not implemented"));

[jkarlin, 2015/02/27 20:08:13]

Use NotSupportedError

[iclelland, 2015/03/02 03:51:11]

Sure -- this isn't intended to survive by the time it gets committed, but I'll
change it anyway, just in case.

+
+    return promise;
+}
+
+void SyncManager::trace(Visitor *visitor)

[jkarlin, 2015/02/27 20:08:13]

DEFINE_TRACE(SyncManager)

[iclelland, 2015/03/02 03:51:11]

Done.

+{
+    visitor->trace(m_registration);
+}
+
+} // namespace blink