Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 963643002: [Android] Remove TestServerSpawner dependency from ChromeNativeTestInstrumentationTestRunner. (Closed)

Created:
5 years, 10 months ago by jbudorick
Modified:
5 years, 9 months ago
Reviewers:
Ted C, cjhopman
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org, ppi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Remove TestServerSpawner dependency from ChromeNativeTestInstrumentationTestRunner. BUG=462239 Committed: https://crrev.com/6b2d16b5072558e38155bb727e4de041e176aac8 Cr-Commit-Position: refs/heads/master@{#318568}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -66 lines) Patch
M build/android/pylib/gtest/local_device_gtest_run.py View 8 chunks +16 lines, -13 lines 0 comments Download
M build/apk_test.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M build/config/android/rules.gni View 1 chunk +0 lines, -1 line 0 comments Download
M testing/android/java/src/org/chromium/native_test/ChromeNativeTestInstrumentationTestRunner.java View 4 chunks +0 lines, -51 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
jbudorick
5 years, 10 months ago (2015-02-27 00:15:58 UTC) #2
Ted C
Is this in a state to review? Just wondering if the comments on the bug ...
5 years, 9 months ago (2015-02-27 20:23:43 UTC) #3
Ted C
On 2015/02/27 20:23:43, Ted C wrote: > Is this in a state to review? Just ...
5 years, 9 months ago (2015-02-27 20:24:32 UTC) #4
Ted C
lgtm
5 years, 9 months ago (2015-02-27 20:25:54 UTC) #5
jbudorick
On 2015/02/27 20:24:32, Ted C wrote: > On 2015/02/27 20:23:43, Ted C wrote: > > ...
5 years, 9 months ago (2015-02-27 20:26:40 UTC) #6
cjhopman
lgtm
5 years, 9 months ago (2015-02-27 23:04:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963643002/1
5 years, 9 months ago (2015-02-27 23:16:07 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/52248)
5 years, 9 months ago (2015-02-28 00:32:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963643002/1
5 years, 9 months ago (2015-02-28 01:04:29 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-28 01:46:25 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-02-28 01:47:12 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b2d16b5072558e38155bb727e4de041e176aac8
Cr-Commit-Position: refs/heads/master@{#318568}

Powered by Google App Engine
This is Rietveld 408576698