Issue 963593004: Shrink space required by history log file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 963593004: Shrink space required by history log file (Closed)

Created:
5 years, 10 months ago by Steve McKay

Modified:
5 years, 10 months ago

Reviewers:

CC:
chromium-reviews, tfarina, rginda+watch_chromium.org, mtomasz+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2311

Target Ref:
refs/pending/branch-heads/2311

Project:
chromium

Visibility:
Public.

More Reviews

Description

Shrink space required by history log file 1) Use seconds-since-epoch in log record keys, instead of full date strings. 2) Add support for inflating/deflating urls. 3) Deflate URLS prior to storaing in log file. 4) Remove obsolete code for reloading history after remote changes. BUG=461176 TEST=browser_test: FileManagerJsTest.* Review URL: https://codereview.chromium.org/954583004 Cr-Commit-Position: refs/heads/master@{#317965} (cherry picked from commit 1f0ca0da1b05c4ac1781063fcf7cfbb195e2a606) TBR=mtomasz Committed: https://chromium.googlesource.com/chromium/src/+/95335acb2c3251726144cfbde6ea82bae631171c

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+155 lines, -249 lines)			Patch
M	ui/file_manager/file_manager/background/js/import_history.js	View	16 chunks	+53 lines, -122 lines	0 comments	Download
M	ui/file_manager/file_manager/background/js/import_history_unittest.js	View	5 chunks	+10 lines, -93 lines	0 comments	Download
M	ui/file_manager/file_manager/common/js/importer_common.js	View	6 chunks	+59 lines, -33 lines	0 comments	Download
M	ui/file_manager/file_manager/common/js/importer_common_unittest.js	View	1 chunk	+33 lines, -0 lines	0 comments	Download
M	ui/file_manager/file_manager/foreground/js/file_manager.js	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Steve McKay

5 years, 10 months ago (2015-02-26 22:48:24 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
95335acb2c3251726144cfbde6ea82bae631171c (presubmit successful).

Expand Messages | Collapse Messages